-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Post Django 3.2 cleanup #151
Conversation
4a4e950
to
ef26096
Compare
@@ -1,9 +1,20 @@ | |||
amqp==5.0.9 | |||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was supposed to have celery44 dependencies in it but in the last Upgrade Job these were updated mistakenly as they were not constrained. I have done a workaround to keep these requirements constrained and also made necessary changes for celery50 requirements.
ef26096
to
58a45a6
Compare
# Let tox control the Django version for tests | ||
grep -e "^amqp==\|^anyjson==\|^billiard==\|^celery==\|^kombu==\|^click-didyoumean==\|^click-repl==\|^click==\|^prompt-toolkit==\|^vine==" requirements/base.txt > requirements/celery44.txt | ||
grep -e "^amqp==\|^anyjson==\|^billiard==\|^celery==\|^kombu==\|^click-didyoumean==\|^click-repl==\|^click==\|^prompt-toolkit==\|^vine==" requirements/base.txt > requirements/celery52.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, we don't want to maintain a celery44
dependencies list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should've added a file for celery50
instead of replacing celery44
with celery50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grep -e "^amqp==\|^anyjson==\|^billiard==\|^celery==\|^kombu==\|^click-didyoumean==\|^click-repl==\|^click==\|^prompt-toolkit==\|^vine==" requirements/base.txt > requirements/celery52.txt | |
grep -e "^amqp==\|^anyjson==\|^billiard==\|^celery==\|^kombu==\|^click-didyoumean==\|^click-repl==\|^click==\|^prompt-toolkit==\|^vine==" requirements/base.txt > requirements/celery44.txt | |
grep -e "^amqp==\|^anyjson==\|^billiard==\|^celery==\|^kombu==\|^click-didyoumean==\|^click-repl==\|^click==\|^prompt-toolkit==\|^vine==" requirements/base.txt > requirements/celery52.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest requirements will only contain packages according to celery52
so adding the suggested step will only create duplicate celery44.txt
and celery52.txt
files.
In the make upgrade step, we can only fetch the requirements for the latest supported version so the requirements for celery44.txt
are being generated with celery44.in
now.
58a45a6
to
8dc06a0
Compare
ea01048
to
50f1297
Compare
JIRA: BOM-3181
DESC
This PR is a part of Django32 cleanup effort which aims at dropping outdated Django versions and also adding Django40 support.
Additional information from script execution
Python code cleanup by the cleanup-python-code Jenkins job.
This pull request was generated by the cleanup-python-code Jenkins job, which ran
The following packages were installed:
edx-repo-tools django-codemod
Deleted obsolete pull_requests:
#148