Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove username from the registration from #1241

Merged
merged 1 commit into from
May 2, 2024

Conversation

syedsajjadkazmii
Copy link
Contributor

@syedsajjadkazmii syedsajjadkazmii commented Apr 22, 2024

Description

Context
To simplify the registration process for edX, we are removing the username from the registration form. To facilitate the removal of the username from the UX (username instances and registration form), we will auto-generate the username at the time of registration using a pre-defined format.

PR changes:

  • Removing username from registration form if ENABLE_AUTO_GENERATED_USERNAME is enabled.
  • Removing username from registration API payload (This will autogenerate username on backend).

JIRA

VAN-1913

How Has This Been Tested?

Locally

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if its not applicable.

Before After

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/2u-vanguards to do it.
  • 馃帀 馃檶 Celebrate! Thanks for your contribution.

@syedsajjadkazmii syedsajjadkazmii requested a review from a team as a code owner April 22, 2024 10:50
@syedsajjadkazmii syedsajjadkazmii changed the title feat: remove username from the registration from (#1201) feat: remove username from the registration from Apr 22, 2024
Copy link
Contributor

@mubbsharanwar mubbsharanwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure username is not set in any event if the flag is enabled.

@syedsajjadkazmii
Copy link
Contributor Author

syedsajjadkazmii commented Apr 25, 2024

Please make sure username is not set in any event if the flag is enabled.

Checked. No such instances found.

@syedsajjadkazmii syedsajjadkazmii merged commit 73e8913 into master May 2, 2024
5 checks passed
@syedsajjadkazmii syedsajjadkazmii deleted the simplify-registration branch May 2, 2024 03:55
mubbsharanwar added a commit that referenced this pull request Jun 7, 2024
* feat: Hide preloaders for third party auth providers if they are disabled

* feat: remove username from the registration from (#1201) (#1241)

Co-authored-by: Attiya Ishaque <atiya.ishaq@arbisoft.com>

* fix: add new entry for another US label (#1244)

Add new entry for for another US label which is United States

* feat: implement multi step registration experiment

Rebase 2u main with master (#1228)

* chore(deps): update dependency babel-plugin-formatjs to v10.5.14

* fix(deps): update dependency @edx/frontend-platform to v7.1.3

* fix(deps): update font awesome to v6.5.2

* chore(deps): update dependency @openedx/frontend-build to v13.1.4

* fix(deps): update dependency @openedx/paragon to v22.2.1

* fix(deps): update dependency algoliasearch to v4.23.3

* fix(deps): update dependency algoliasearch-helper to v3.17.0

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat: add multi step registration eventing (#1226)

* feat: implement multi step registration experiment

* feat: add multi step registration eventing

* fix: fix register button width

* fix: fix register button loader for control

* feat: capture marketing lead in experiment events (#1243)

* revert: multistep registration experiment
revert multistep registration experiment changes

VAN-1930

* feat: implement auto generated username experiment (#1248)

* feat: implement auto generated username registration exp

* feat: add page event for reset password (#1253)

Description: Add page event for reset password page
VAN-1929

---------

Co-authored-by: Stanislav Lunyachek <stanislav.lunyachek@raccoongang.com>
Co-authored-by: Syed Sajjad Hussain Shah <52817156+syedsajjadkazmii@users.noreply.github.com>
Co-authored-by: Attiya Ishaque <atiya.ishaq@arbisoft.com>
Co-authored-by: Blue <ahtesham-quraish@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Syed Sajjad  Hussain Shah <ssajjad@2u.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants