fix: Registration occurs with a password that does not meet the requirements to Quince

[DmytroAlipov]

This is a backport from the master branch.

Description

The behavior of the registration form is very different from the behavior of this form for the Palm release.
Even with incorrectly filled fields, the form can still be submitted. In certain instances, registration may succeed, such as when the password consists of merely two characters.

There’s an issue where the error message doesn’t disappear even after the error is corrected and the focus is shifted to another field. Here’s how to reproduce it:

1. Fill in all fields correctly.
2. Enter a username or email with a space.
3. Submit a request to create an account.
4. An error will appear in the field where there is a space.
5. The cursor should already be in the field with the error (so there’s no need to click on this field again). Remove the space.
6. Move the cursor to another field.
7. The error message remains for the field where the space was initially present, even though it has been corrected.

My proposals are aimed at returning the behavior as happened on Palm.

PS: I’ve noticed that you’ve been conducting numerous experiments on the master branch. To avoid any conflicts, I’ve refrained from making these changes directly to the master. If there are any upcoming plans for the registration page, please consider these issues before the release of Redwood.

Screenshots/sandbox (optional):

• Before

after clicking on "Create an account for free" button (the request to the backend is still sent even if there is a space):

• After

prevent a request to the backend if the password does not meet the conditions:

Post-merge Checklist

• Deploy the changes to prod after verifying on stage or ask @openedx/2u-vanguards to do it.
• 🎉 🙌 Celebrate! Thanks for your contribution.

[openedx-webhooks]

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/quince.master@abea379). Click here to learn what that means.

Additional details and impacted files

@@                      Coverage Diff                      @@
##             open-release/quince.master    #1182   +/-   ##
=============================================================
  Coverage                              ?   87.14%           
=============================================================
  Files                                 ?      124           
  Lines                                 ?     2295           
  Branches                              ?      635           
=============================================================
  Hits                                  ?     2000           
  Misses                                ?      286           
  Partials                              ?        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[arbrandes]

@DmytroAlipov, nice catch, thanks! Can you submit a PR to master first, if it doesn't already exist? If it does, can you point to it here?

[DmytroAlipov]

Hi @arbrandes I noticed that experiments were being conducted in the master branch of this MFE. I wanted to ask the contributors whether changes should be made to the master branch.

[DmytroAlipov]

@DmytroAlipov, nice catch, thanks! Can you submit a PR to master first, if it doesn't already exist? If it does, can you point to it here?

done

[DmytroAlipov]

@arbrandes @syedsajjadkazmii Everything is done for both Master and Quince.

[arbrandes]

Great! Let's wait to merge this until the master PR lands, though.

[syedsajjadkazmii]

Hi @DmytroAlipov, master PR have been merged. Please look at this comment and make that change in this branch too.

[DmytroAlipov]

Hi @syedsajjadkazmii
If we are talking about this, then I already did this when it was changed in the master:

if (registrationError[name]) {
  dispatch(clearRegistrationBackendError(name));
}

[syedsajjadkazmii]

this can be removed

[DmytroAlipov]

Hi @syedsajjadkazmii
Why remove validateUsername and validateName? Or was this noted by chance?

[syedsajjadkazmii]

Hi @syedsajjadkazmii Why remove validateUsername and validateName? Or was this noted by chance?

I only meant for emailRegex. Github picked those lines as well. :)

[openedx-webhooks]

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.