Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include org filter when requesting LTI providers #1114

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

rijuma
Copy link
Member

@rijuma rijuma commented Jun 19, 2024

Description

Passes on the organization to the LTI providers endpoint for use to filter.

Added quality of life change

Updated the CI tests to be silent (hides console output). The change reduced CI test generated logs from 35MB to 298KB.

@rijuma rijuma force-pushed the rijuma/add-org-to-lti-providers-request branch 3 times, most recently from e60bac3 to 3407975 Compare June 20, 2024 13:29
@rijuma rijuma force-pushed the rijuma/add-org-to-lti-providers-request branch from 3407975 to b7bcbe4 Compare June 20, 2024 13:33
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (088a01d) to head (70b5bc7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1114   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files         710      710           
  Lines       12683    12683           
  Branches     2798     2764   -34     
=======================================
  Hits        11744    11744           
  Misses        903      903           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rijuma rijuma marked this pull request as ready for review June 20, 2024 14:13
@rijuma rijuma requested a review from a team as a code owner June 20, 2024 14:13
@rijuma rijuma merged commit 3936737 into master Jun 20, 2024
6 checks passed
@rijuma rijuma deleted the rijuma/add-org-to-lti-providers-request branch June 20, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants