Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade react router to v6 #519

Merged
merged 10 commits into from
Oct 20, 2023
Merged

Conversation

Syed-Ali-Abbas-Zaidi
Copy link
Contributor

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi commented Jun 14, 2023

Ticket

React Router Upgrade to v6.

Description

This PR upgrades React Router from v5 to v6.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi self-assigned this Jun 14, 2023
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi marked this pull request as draft June 14, 2023 05:02
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (682c3b6) 86.56% compared to head (228773e) 86.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
+ Coverage   86.56%   86.73%   +0.17%     
==========================================
  Files         387      388       +1     
  Lines        5776     5783       +7     
  Branches     1272     1267       -5     
==========================================
+ Hits         5000     5016      +16     
+ Misses        751      742       -9     
  Partials       25       25              
Files Coverage Δ
src/CourseAuthoringRoutes.jsx 100.00% <100.00%> (ø)
src/course-rerun/index.jsx 100.00% <100.00%> (ø)
src/custom-pages/CustomPageCard.jsx 100.00% <100.00%> (ø)
src/editors/EditorContainer.jsx 100.00% <ø> (ø)
...create-or-rerun-course/CreateOrRerunCourseForm.jsx 88.70% <ø> (ø)
src/pages-and-resources/PagesAndResources.jsx 85.18% <100.00%> (+19.47%) ⬆️
...-and-resources/discussions/DiscussionsSettings.jsx 96.87% <100.00%> (+0.10%) ⬆️
...sources/discussions/app-list/AppListNextButton.jsx 100.00% <100.00%> (ø)
src/pages-and-resources/live/Settings.jsx 90.24% <100.00%> (+0.24%) ⬆️
...es/xpert-unit-summary/XpertUnitSummarySettings.jsx 100.00% <100.00%> (ø)
... and 9 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi force-pushed the Ali-Abbas/react-router-upgrade branch 6 times, most recently from 4d2900a to c7cd1d8 Compare October 17, 2023 11:17
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi marked this pull request as ready for review October 17, 2023 11:17
@jesperhodge jesperhodge merged commit d497b01 into master Oct 20, 2023
5 of 6 checks passed
@jesperhodge jesperhodge deleted the Ali-Abbas/react-router-upgrade branch October 20, 2023 20:52
bra-i-am pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Apr 30, 2024
[React Router Upgrade to v6](openedx/platform-roadmap#276).

This PR upgrades React Router from `v5` to `v6`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants