Skip to content

Commit

Permalink
Revert "feat: use frontend-plugin-framework to provide a FooterSlot" (#…
Browse files Browse the repository at this point in the history
…700)

This reverts commit d747478.
  • Loading branch information
awais-ansari committed May 13, 2024
1 parent d747478 commit 4de1011
Show file tree
Hide file tree
Showing 8 changed files with 4,859 additions and 7,301 deletions.
6 changes: 0 additions & 6 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,6 @@ Cloning and Startup

The dev server is running at `http://localhost:2002 <http://localhost:2002>`_.

Plugins
=======
This MFE can be customized using `Frontend Plugin Framework <https://github.com/openedx/frontend-plugin-framework>`_.

The parts of this MFE that can be customized in that manner are documented `here </src/plugin-slots>`_.

Getting Help
============
Please tag **@openedx/edx-infinity ** on any PRs or issues. Thanks.
Expand Down
12,094 changes: 4,856 additions & 7,238 deletions package-lock.json

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,10 @@
},
"dependencies": {
"@edx/brand": "npm:@openedx/brand-openedx@^1.2.2",
"@edx/frontend-component-footer": "^13.2.0",
"@edx/frontend-component-footer": "^13.0.2",
"@edx/frontend-component-header": "^5.0.2",
"@edx/frontend-platform": "^7.1.0",
"@edx/openedx-atlas": "^0.6.0",
"@openedx/frontend-plugin-framework": "^1.1.2",
"@openedx/paragon": "^22.1.1",
"@reduxjs/toolkit": "1.9.7",
"@tinymce/tinymce-react": "3.13.1",
Expand Down
4 changes: 2 additions & 2 deletions src/discussions/discussions-home/DiscussionsHome.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import { selectPostEditorVisible } from '../posts/data/selectors';
import { isCourseStatusValid } from '../utils';
import useFeedbackWrapper from './FeedbackWrapper';

const FooterSlot = lazy(() => import('@edx/frontend-component-footer').then(module => ({ default: module.FooterSlot })));
const Footer = lazy(() => import('@edx/frontend-component-footer'));
const PostActionsBar = lazy(() => import('../posts/post-actions-bar/PostActionsBar'));
const CourseTabsNavigation = lazy(() => import('../../components/NavigationBar/CourseTabsNavigation'));
const LegacyBreadcrumbMenu = lazy(() => import('../navigation/breadcrumb-menu/LegacyBreadcrumbMenu'));
Expand Down Expand Up @@ -175,7 +175,7 @@ const DiscussionsHome = () => {
)}
{!enableInContextSidebar && isEnrolled && (<DiscussionsProductTour />)}
</main>
{!enableInContextSidebar && <FooterSlot />}
{!enableInContextSidebar && <Footer />}
</DiscussionContext.Provider>
</Suspense>
);
Expand Down
50 changes: 0 additions & 50 deletions src/plugin-slots/FooterSlot/README.md

This file was deleted.

Binary file removed src/plugin-slots/FooterSlot/images/custom_footer.png
Binary file not shown.
Binary file not shown.
3 changes: 0 additions & 3 deletions src/plugin-slots/README.md

This file was deleted.

0 comments on commit 4de1011

Please sign in to comment.