fix: update post when comment is marked as answer; reload topics on open [BD-38] [TNL-9646] [TNL-9703] #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openedx-webhooks
added
blended
|
Thanks for the pull request, @xitij2000! I've created BLENDED-1163 to keep track of it in Jira. More details are on the BD-38 project page. When this pull request is ready, tag your edX technical lead. |
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
+ Coverage 85.41% 86.34% +0.92%
==========================================
Files 100 100
Lines 1838 1845 +7
Branches 451 452 +1
==========================================
+ Hits 1570 1593 +23
+ Misses 253 238 -15
+ Partials 15 14 -1
Continue to review full report at Codecov.
|
navinkarkera
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
👍
- I tested this: (checked video of the expected behaviour)
- I read through the code
- I checked for accessibility issues
- Includes documentation
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
xitij2000
changed the title
When a comment is marked as an answer, refresh the post it's in so the answered tag appears. When navigating to the post tab, refresh the topic list.
xitij2000
force-pushed
the
kshitij/tnl-9646
branch
from
ddf8cda
to
59d0932
Compare
awais-ansari
approved these changes
Mar 28, 2022
|
@xitij2000 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
moonesque
pushed a commit
to edSPIRIT/frontend-app-discussions
that referenced
this pull request
Nov 12, 2023
… according to figma (openedx#104) Co-authored-by: MehakNasir <mehaknasir@A006-00194.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a comment is marked as an answer, refresh the post it's in so the answered tag appears.
When navigating to the post tab, refresh the topic list.
Peek.2022-03-25.15-43.mp4