feat: Support runtime configuration #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
arbrandes
force-pushed
the
support-runtime-config
branch
from
8f425b0
to
3cd1aee
Compare
Codecov ReportBase: 84.97% // Head: 84.95% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #377 +/- ##
==========================================
- Coverage 84.97% 84.95% -0.03%
==========================================
Files 134 134
Lines 2736 2731 -5
Branches 759 759
==========================================
- Hits 2325 2320 -5
Misses 389 389
Partials 22 22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
arbrandes
pushed a commit
to arbrandes/frontend-app-discussions
that referenced
this pull request
Dec 8, 2022
frontend-platform supports runtime configuration since 2.5.0 (see the PR that introduced it[1], but it requires MFE cooperation. This implements just that: by avoiding making configuration values constant, it should now be possible to change them after initialization. Almost all changes here relate to the `LMS_BASE_URL` setting, which in most places was treated as a constant. [1] openedx/frontend-platform#335 This is a backport to Olive of openedx#377
frontend-platform supports runtime configuration since 2.5.0 (see the PR that introduced it[1], but it requires MFE cooperation. This implements just that: by avoiding making configuration values constant, it should now be possible to change them after initialization. Almost all changes here relate to the `LMS_BASE_URL` setting, which in most places was treated as a constant. [1] openedx/frontend-platform#335
arbrandes
force-pushed
the
support-runtime-config
branch
from
3cd1aee
to
965fd08
Compare
awais-ansari
approved these changes
Dec 9, 2022
|
Thanks for the review, @awais-ansari! Much appreciated! |
arbrandes
pushed a commit
that referenced
this pull request
Dec 9, 2022
frontend-platform supports runtime configuration since 2.5.0 (see the PR that introduced it[1], but it requires MFE cooperation. This implements just that: by avoiding making configuration values constant, it should now be possible to change them after initialization. Almost all changes here relate to the `LMS_BASE_URL` setting, which in most places was treated as a constant. [1] openedx/frontend-platform#335 This is a backport to Olive of #377
sambapete
pushed a commit
to EDUlib/frontend-app-discussions
that referenced
this pull request
Apr 11, 2023
frontend-platform supports runtime configuration since 2.5.0 (see the PR that introduced it[1], but it requires MFE cooperation. This implements just that: by avoiding making configuration values constant, it should now be possible to change them after initialization. Almost all changes here relate to the `LMS_BASE_URL` setting, which in most places was treated as a constant. [1] openedx/frontend-platform#335 This is a backport to Olive of openedx#377
sambapete
pushed a commit
to EDUlib/frontend-app-discussions
that referenced
this pull request
Jun 14, 2023
frontend-platform supports runtime configuration since 2.5.0 (see the PR that introduced it[1], but it requires MFE cooperation. This implements just that: by avoiding making configuration values constant, it should now be possible to change them after initialization. Almost all changes here relate to the `LMS_BASE_URL` setting, which in most places was treated as a constant. [1] openedx/frontend-platform#335 This is a backport to Olive of openedx#377
snglth
pushed a commit
to Abstract-Tech/community-theme-discussions
that referenced
this pull request
Jul 5, 2023
frontend-platform supports runtime configuration since 2.5.0 (see the PR that introduced it[1], but it requires MFE cooperation. This implements just that: by avoiding making configuration values constant, it should now be possible to change them after initialization. Almost all changes here relate to the `LMS_BASE_URL` setting, which in most places was treated as a constant. [1] openedx/frontend-platform#335 This is a backport to Olive of openedx#377
sambapete
pushed a commit
to EDUlib/frontend-app-discussions
that referenced
this pull request
Aug 9, 2023
frontend-platform supports runtime configuration since 2.5.0 (see the PR that introduced it[1], but it requires MFE cooperation. This implements just that: by avoiding making configuration values constant, it should now be possible to change them after initialization. Almost all changes here relate to the `LMS_BASE_URL` setting, which in most places was treated as a constant. [1] openedx/frontend-platform#335 This is a backport to Olive of openedx#377
sambapete
pushed a commit
to EDUlib/frontend-app-discussions
that referenced
this pull request
Oct 11, 2023
frontend-platform supports runtime configuration since 2.5.0 (see the PR that introduced it[1], but it requires MFE cooperation. This implements just that: by avoiding making configuration values constant, it should now be possible to change them after initialization. Almost all changes here relate to the `LMS_BASE_URL` setting, which in most places was treated as a constant. [1] openedx/frontend-platform#335 This is a backport to Olive of openedx#377
sambapete
pushed a commit
to EDUlib/frontend-app-discussions
that referenced
this pull request
Oct 13, 2023
frontend-platform supports runtime configuration since 2.5.0 (see the PR that introduced it[1], but it requires MFE cooperation. This implements just that: by avoiding making configuration values constant, it should now be possible to change them after initialization. Almost all changes here relate to the `LMS_BASE_URL` setting, which in most places was treated as a constant. [1] openedx/frontend-platform#335 This is a backport to Olive of openedx#377
moonesque
pushed a commit
to edSPIRIT/frontend-app-discussions
that referenced
this pull request
Nov 12, 2023
sambapete
pushed a commit
to EDUlib/frontend-app-discussions
that referenced
this pull request
Nov 17, 2023
frontend-platform supports runtime configuration since 2.5.0 (see the PR that introduced it[1], but it requires MFE cooperation. This implements just that: by avoiding making configuration values constant, it should now be possible to change them after initialization. Almost all changes here relate to the `LMS_BASE_URL` setting, which in most places was treated as a constant. [1] openedx/frontend-platform#335 This is a backport to Olive of openedx#377
sambapete
pushed a commit
to EDUlib/frontend-app-discussions
that referenced
this pull request
Dec 11, 2023
frontend-platform supports runtime configuration since 2.5.0 (see the PR that introduced it[1], but it requires MFE cooperation. This implements just that: by avoiding making configuration values constant, it should now be possible to change them after initialization. Almost all changes here relate to the `LMS_BASE_URL` setting, which in most places was treated as a constant. [1] openedx/frontend-platform#335 This is a backport to Olive of openedx#377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frontend-platform supports runtime configuration since 2.5.0 (see the PR that introduced it), but it requires MFE cooperation. This implements just that: by avoiding making configuration values constant, it should now be possible to change them after initialization.
Almost all changes here relate to the
LMS_BASE_URLsetting, which in most places was treated as a constant.Testing
This should be a NOOP for any deployments of the MFE that don't make explicit use of runtime configuration. This is reflected in all unit tests, which needed little to no significant modifications. This change should have no effect on usage of this MFE in the devstack or in current production deployments.
To actually see the desired effects of the change, one needs to deploy Tutor with the correspondingly modified tutor-mfe plugin. Where before several features would fail (adding a post, navigating to the topics page, etc), they should all now work.