feat: Support runtime configuration (second attempt) #386
Conversation
Codecov ReportBase: 84.71% // Head: 84.68% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #386 +/- ##
==========================================
- Coverage 84.71% 84.68% -0.03%
==========================================
Files 134 134
Lines 2761 2756 -5
Branches 768 768
==========================================
- Hits 2339 2334 -5
Misses 400 400
Partials 22 22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@arbrandes have you updated anything in this PR? OR do you want to just merge and try to debug on stage? |
|
As noted on the parent issue, no changes here yet. Going to do another visual pass. |
(This reintroduces the change in 9f84230 that was later reverted by 67b0b33.) frontend-platform supports runtime configuration since 2.5.0 (see the PR that introduced it[1], but it requires MFE cooperation. This implements just that: by avoiding making configuration values constant, it should now be possible to change them after initialization. Almost all changes here relate to the `LMS_BASE_URL` setting, which in most places was treated as a constant. [1] openedx/frontend-platform#335
mehaknasir
force-pushed
the
runtime-configuration-support
branch
from
db8984e
to
b0cac75
Compare
…launch email optional (openedx#380)" (openedx#386) This reverts commit b8895be.
(This reintroduces the change in 9f84230 that was later reverted by 67b0b33.)
frontend-platform supports runtime configuration since 2.5.0 (see the PR that introduced it[1], but it requires MFE cooperation. This implements just that: by avoiding making configuration values constant, it should now be possible to change them after initialization.
Almost all changes here relate to the
LMS_BASE_URLsetting, which in most places was treated as a constant.[1] openedx/frontend-platform#335