-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Profile image on user posts (palm.master) #573
base: open-release/palm.master
Are you sure you want to change the base?
feat: Profile image on user posts (palm.master) #573
Conversation
Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@vladislavkeblysh Thank you for this contribution! |
Hi @vladislavkeblysh! Just flagging that there is a failing check. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## open-release/palm.master #573 +/- ##
============================================================
+ Coverage 92.38% 92.41% +0.02%
============================================================
Files 163 162 -1
Lines 3297 3282 -15
Branches 890 887 -3
============================================================
- Hits 3046 3033 -13
+ Misses 232 230 -2
Partials 19 19 ☔ View full report in Codecov by Sentry. |
@vladislavkeblysh Looks like there are some coverage issues, can you have a look? |
@itsjeyd The coverage issues are not related to the new code added in this PR. It seems like this has been carrying over from previous PRs. |
@vladislavkeblysh I see -- the line that the codecov check is complaining about wasn't changed in this PR. Thanks for checking. That probably means it's OK to merge the changes as is, but it'll be up to engineering reviewers to make the final call on that. |
@vladislavkeblysh This change was intentional. This feature is still in product discussion. |
c83160d
to
25221c9
Compare
Description