Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Profile image on user posts (palm.master) #573

Open
wants to merge 3 commits into
base: open-release/palm.master
Choose a base branch
from

Conversation

vladislavkeblysh
Copy link
Contributor

@vladislavkeblysh vladislavkeblysh commented Oct 11, 2023

Description

  • Added profile image on user avatar posts

Screenshot 2023-10-11 at 19 01 23

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 11, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 11, 2023

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@vladislavkeblysh vladislavkeblysh changed the title feat: Profile image on user posts feat: Profile image on user posts (palm.master) Oct 11, 2023
@vladislavkeblysh vladislavkeblysh marked this pull request as draft October 11, 2023 16:49
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 11, 2023
@vladislavkeblysh vladislavkeblysh marked this pull request as ready for review October 12, 2023 08:16
@itsjeyd
Copy link

itsjeyd commented Oct 17, 2023

@vladislavkeblysh Thank you for this contribution!

@itsjeyd itsjeyd added the backport PR backports a change from main to a named release. label Oct 17, 2023
@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 17, 2023
@mphilbrick211
Copy link

Hi @vladislavkeblysh! Just flagging that there is a failing check.

@itsjeyd itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. product review PR requires product review before merging labels Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dcb0f9e) 92.38% compared to head (25221c9) 92.41%.
Report is 4 commits behind head on open-release/palm.master.

Files Patch % Lines
...c/discussions/discussions-home/FeedbackWrapper.jsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           open-release/palm.master     #573      +/-   ##
============================================================
+ Coverage                     92.38%   92.41%   +0.02%     
============================================================
  Files                           163      162       -1     
  Lines                          3297     3282      -15     
  Branches                        890      887       -3     
============================================================
- Hits                           3046     3033      -13     
+ Misses                          232      230       -2     
  Partials                         19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsjeyd
Copy link

itsjeyd commented Nov 2, 2023

@vladislavkeblysh Looks like there are some coverage issues, can you have a look?

@vladislavkeblysh
Copy link
Contributor Author

@itsjeyd The coverage issues are not related to the new code added in this PR. It seems like this has been carrying over from previous PRs.

@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 8, 2023
@itsjeyd
Copy link

itsjeyd commented Nov 8, 2023

@vladislavkeblysh I see -- the line that the codecov check is complaining about wasn't changed in this PR. Thanks for checking.

That probably means it's OK to merge the changes as is, but it'll be up to engineering reviewers to make the final call on that.

@awais-ansari
Copy link
Contributor

@vladislavkeblysh This change was intentional. This feature is still in product discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U product review PR requires product review before merging
Projects
Status: Product Review
Development

Successfully merging this pull request may close these issues.

None yet

5 participants