Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MFE runtime configuration API #724

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

PKulkoRaccoonGang
Copy link

@PKulkoRaccoonGang PKulkoRaccoonGang commented Jun 30, 2024

Description

This pull request provides a sandbox for testing MFE runtime configurations.

Example config:

{
    "MFE_CONFIG_OVERRIDES": {
        "discussions": {
            "PARAGON_THEME_URLS": {
                "core": {
                    "urls": {
                        "default": "https://cdn.jsdelivr.net/npm/@openedx/paragon@$paragonVersion/dist/core.min.css"
                    }
                },
                "defaults": {
                    "light": "light",
                    "dark": "dark"
                },
                "variants": {
                    "light": {
                        "urls": {
                            "default": "https://cdn.jsdelivr.net/npm/@openedx/paragon@$paragonVersion/dist/light.min.css"
                        }
                    },
                    "dark": {
                        "urls": {
                            "default": "https://cdn.jsdelivr.net/npm/@edx/brand-edx.org@alpha/dist/light.min.css"
                        }
                    }
                }
            }
        }
    }
}

Info

Related PRs

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 30, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 30, 2024

Thanks for the pull request, @PKulkoRaccoonGang! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft June 30, 2024 18:49
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.88%. Comparing base (422fbf6) to head (a4cfa22).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #724   +/-   ##
=======================================
  Coverage   92.88%   92.88%           
=======================================
  Files         160      160           
  Lines        3329     3329           
  Branches      888      893    +5     
=======================================
  Hits         3092     3092           
  Misses        219      219           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PKulkoRaccoonGang PKulkoRaccoonGang self-assigned this Jun 30, 2024
@PKulkoRaccoonGang PKulkoRaccoonGang added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Jun 30, 2024
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

refactor: code refactoring

feat: necessary dependencies added

refactor: corrected lint

refactor: corrected sh

refactor: added logs

refactor: added temp frontend-platform dist

refactor: updated run-build-for-gh-deps.sh

refactor: corrected run-build-for-gh-deps.sh

refactor: fixing the problem

refactor: changed run build command

feat: added header

refactor: added dark theme and footer

refactor: code refactoring
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/mfe-runtime-configuration branch from e6ae328 to 267cee1 Compare July 3, 2024 17:23
@PKulkoRaccoonGang PKulkoRaccoonGang added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Jul 3, 2024
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@PKulkoRaccoonGang PKulkoRaccoonGang added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Jul 3, 2024
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@brian-smith-tcril
Copy link
Contributor

I'm not sure where the best place to report this issue is, but when visiting https://app.pr-724-6b242e.sandboxes.opencraft.hosting/discussions/course-v1:openedx+123+2023/posts/66879d5d57bfb4002db05e09 with a small window I noticed a visual bug

Screenshot from 2024-07-05 11-07-15

Screencast.from.2024-07-05.11-07-00.webm

@dcoa
Copy link

dcoa commented Jul 6, 2024

I remove the dark mode configuration to load only the Paragon light theme and avoid the reported issue.

C.C @PKulkoRaccoonGang @brian-smith-tcril

@PKulkoRaccoonGang PKulkoRaccoonGang changed the title testing: MFE runtime configuration API feat: MFE runtime configuration API Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

None yet

5 participants