Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Hard-coded link in Header component changed by LMS_BASE_URL env var #186

Merged
merged 4 commits into from
Jun 14, 2021
Merged

fix: Hard-coded link in Header component changed by LMS_BASE_URL env var #186

merged 4 commits into from
Jun 14, 2021

Commits on May 25, 2021

  1. feat: LOGO_DESTINATION env var added for use it on Header component 

    On index.js file of the Header component, currenly there is a hard-coded link of "https://www.edx.org". I added a new enviroment variable LOGO_DESTINATION to use it in this Header.
I have also added a mechanism to use the LMS_BASE_URL environment variable if the LOGO_DESTINATION environment variable is not found or is null.
    @ChrisChV
    ChrisChV committed May 25, 2021
    Configuration menu
    Copy the full SHA
    7c1e4ef View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. fix: Hard-coded link in Header component changed by a env var 

    `index.jsx` file of Header component updated with change the hard-coded link of https://www.edx.org with a component property.
`index.jsx` file of root project updated. Added the environment variable LMS BASE_URL to the parameters of the Header Component
    @ChrisChV
    ChrisChV committed May 28, 2021
    Configuration menu
    Copy the full SHA
    ffe3aaa View commit details
    Browse the repository at this point in the history

Commits on May 31, 2021

  1. fix: lint errors in previous commits

    @ChrisChV
    ChrisChV committed May 31, 2021
    Configuration menu
    Copy the full SHA
    5356eef View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2021

  1. style: change structure of the solution

    @ChrisChV
    ChrisChV committed Jun 5, 2021
    Configuration menu
    Copy the full SHA
    5b10369 View commit details
    Browse the repository at this point in the history