fix: replace Field.Email reference for Field.Text

[dcoa]

Description
The master branch doesn't have the references to new Field.Text updated, there is a screenshot of the error

As well useGradeButtonData doesn't return a string in the label field is returning a function, so the numbers weren't render

This PR tries to solve that rendering situation.

What changed?

• Update the reference for Field.Email to Field.Text
• Update the test.

Developer Checklist

• Test suites passing
• Documentation and test plan updated, if applicable
• Received code-owner approving review
• Bumped version number package.json

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

• I've done a visual code review
• I've tested the new functionality

FYI: @openedx/content-aurora

[openedx-webhooks]

Thanks for the pull request, @dcoa! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (44197f6) 94.93% compared to head (e10ef6d) 94.93%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files         139      139           
  Lines        1343     1343           
  Branches      264      264           
=======================================
  Hits         1275     1275           
  Misses         60       60           
  Partials        8        8           

Files Changed	Coverage Δ
src/components/GradesView/GradebookTable/hooks.jsx	100.00% <ø> (ø)
...mponents/GradesView/GradebookTable/GradeButton.jsx	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[arslanashraf7]

Hey @mphilbrick211 we are facing the same issue while running the gradebook locally and on a server. Is it possible by any chance that the review on this PR could be prioritized?

[mphilbrick211]

Hey @mphilbrick211 we are facing the same issue while running the gradebook locally and on a server. Is it possible by any chance that the review on this PR could be prioritized?

Hi @openedx/content-aurora! Flagging this - would someone be able to please review?

[dcoa]

@muselesscreator @leangseu-edx

Hi folks, could you help us with a review in his PR or help us identify the right reviewer?

[arbrandes]

The changes make sense, but I'm worried the bugs they fix weren't caught by any tests to begin with. Would it be too much to ask to add some tests that would've done so?

[dcoa]

Hi @arbrandes thank you for your review and not 100% sure to understand your request because when I used the branch I realized that the reason why the test didn't catch the errors was because the testing for this component and function was correct: Field.Text test and subsectionGrade test only the reference was not updated and not fail because of the use of jest.mock.

I updated the test reference too, or I just can think of using the original component instead of mocking it but that does not make the test fail only displays a console.error

[arbrandes]

Yeah, it might be going overboard to test for this retroactively, here. I feel like it would initiate a full revamp, which would probably be better planned elsewhere. (As part of the migration to react-testing-library, perhaps.) Let's just fix the glaring issue and move on, for now.

[openedx-webhooks]

@dcoa 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.