feat: Added i18n for search header component. #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saleem-latif
requested review from
muhammad-ammar,
irfanuddinahmad and
jajjibhai008
saleem-latif
force-pushed
the
saleem-latif/ENT-8580
branch
from
9777592
to
c64cbc7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1084 +/- ##
==========================================
+ Coverage 86.00% 86.01% +0.01%
==========================================
Files 381 381
Lines 7759 7774 +15
Branches 1893 1894 +1
==========================================
+ Hits 6673 6687 +14
- Misses 1032 1033 +1
Partials 54 54 ☔ View full report in Codecov by Sentry. |
saleem-latif
force-pushed
the
saleem-latif/ENT-8580
branch
2 times, most recently
from
e650568
to
126e423
Compare
jajjibhai008
approved these changes
May 21, 2024
adamstankiewicz
approved these changes
May 21, 2024
package.json
Outdated
| @@ -9,7 +9,7 @@ | |||
| "dependencies": { | |||
| "@edx/brand": "npm:@openedx/brand-openedx@1.2.2", | |||
| "@edx/frontend-component-footer": "13.0.2", | |||
| "@edx/frontend-enterprise-catalog-search": "9.0.0", | |||
| "@edx/frontend-enterprise-catalog-search": "^10.3.0", | |||
There was a problem hiding this comment.
nit: pin the dependency (similar to others; maintain convention) and re-run npm install to update package-lock.json.
saleem-latif
force-pushed
the
saleem-latif/ENT-8580
branch
from
126e423
to
160699a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: ENT-8580
Description:
This PR adds i18n support for search header component.
For all changes
Only if submitting a visual change