Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: renamed careerEngagementNetworkMessage field #1095

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

sameeramin
Copy link
Member

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.00%. Comparing base (79507b9) to head (c864f66).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1095   +/-   ##
=======================================
  Coverage   86.00%   86.00%           
=======================================
  Files         381      381           
  Lines        7796     7796           
  Branches     1900     1867   -33     
=======================================
  Hits         6705     6705           
  Misses       1037     1037           
  Partials       54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamzawaleed01
Copy link
Member

@sameeramin Will this stop rendering sidebar content on FE until new APIs are deployed with field renamed? 🤔

@sameeramin
Copy link
Member Author

@hamzawaleed01 I'll merge this PR after updating the backend

@sameenfatima78 sameenfatima78 merged commit 036eca6 into master Jun 24, 2024
7 checks passed
@sameenfatima78 sameenfatima78 deleted the sameeramin/ENT-9003 branch June 24, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants