Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ExternalCourseEnrollment page - handle no applicable subsidies #1098

Merged

Conversation

pwnage101
Copy link
Contributor

Instead of throwing a JS error, return a 404 page when there are absolutely no applicable subsidies for a given course.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Instead of throwing a JS error, return a 404 page when there are
absolutely no applicable subsidies for a given course.
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.00%. Comparing base (cdc351c) to head (de9cc06).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1098   +/-   ##
=======================================
  Coverage   86.00%   86.00%           
=======================================
  Files         381      381           
  Lines        7796     7798    +2     
  Branches     1902     1903    +1     
=======================================
+ Hits         6705     6707    +2     
  Misses       1037     1037           
  Partials       54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good catch.

@pwnage101 pwnage101 merged commit 284b96f into master Jun 17, 2024
7 checks passed
@pwnage101 pwnage101 deleted the pwnage101/no-applicable-subsidy-404-externalcourseenrollment branch June 17, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants