chore: dependabot warning fixes #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1100 +/- ##
=======================================
Coverage 86.00% 86.00%
=======================================
Files 381 381
Lines 7796 7796
Branches 1902 1867 -35
=======================================
Hits 6705 6705
Misses 1037 1037
Partials 54 54 ☔ View full report in Codecov by Sentry. |
adamstankiewicz
approved these changes
Jun 17, 2024
| @@ -23,13 +23,12 @@ | |||
| "@tanstack/react-query-devtools": "4.29.0", | |||
| "accessible-nprogress": "2.1.2", | |||
| "algoliasearch": "4.6.0", | |||
| "axios": "0.21.1", | |||
| "axios": "0.28.0", | |||
There was a problem hiding this comment.
[curious/suggestion] Is it actually possible to remove axios from this MFE's package.json given axios is installed as a dependency via @edx/frontend-platform (source)?
There was a problem hiding this comment.
@adamstankiewicz, After our async discussion, leaving it as is 👍🏽
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the following package(s) based on dependabot warnings:
axios: 0.21.1 -> 0.28.0Also removes the following unused package(s),
email-prop-type,react-fullstory,reselect,startFor all changes
Only if submitting a visual change