Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ags/storybook docs #636

Closed
wants to merge 4 commits into from
Closed

Ags/storybook docs #636

wants to merge 4 commits into from

Conversation

adamstankiewicz
Copy link
Member

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 78.73% // Head: 78.65% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (d198670) compared to base (df881a1).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
- Coverage   78.73%   78.65%   -0.08%     
==========================================
  Files         263      264       +1     
  Lines        5163     5164       +1     
  Branches     1272     1273       +1     
==========================================
- Hits         4065     4062       -3     
- Misses       1068     1072       +4     
  Partials       30       30              
Impacted Files Coverage Δ
src/components/course/CourseHeader.jsx 100.00% <ø> (ø)
src/components/course/CourseRunCard.jsx 95.83% <ø> (ø)
.../components/enterprise-banner/EnterpriseBanner.jsx 100.00% <ø> (ø)
...ents/executive-education-2u/UserEnrollmentForm.jsx 94.23% <ø> (ø)
src/components/layout/data/hooks.js 10.00% <0.00%> (-5.00%) ⬇️
...rc/components/executive-education-2u/data/utils.js 75.00% <75.00%> (ø)
src/components/course/SubsidyRequestButton.jsx 89.36% <100.00%> (-4.64%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adamstankiewicz adamstankiewicz deleted the ags/storybook-docs branch January 10, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant