feat: upgrade react router to v6 #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al-enterprise into Ali-Abbas/react-router-upgrade
…al-enterprise into Ali-Abbas/react-router-upgrade
…al-enterprise into Ali-Abbas/react-router-upgrade
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #776 +/- ##
==========================================
+ Coverage 84.87% 85.00% +0.13%
==========================================
Files 320 324 +4
Lines 6399 6704 +305
Branches 1552 1626 +74
==========================================
+ Hits 5431 5699 +268
- Misses 941 974 +33
- Partials 27 31 +4
☔ View full report in Codecov by Sentry. |
Syed-Ali-Abbas-Zaidi
force-pushed
the
Ali-Abbas/react-router-upgrade
branch
from
a6cc833
to
dba2db1
Compare
kiram15
approved these changes
Oct 4, 2023
| <Route path="/:enterpriseSlug" component={EnterpriseAppPageRoutes} /> | ||
| <PageRoute path="*" component={NotFoundPage} /> | ||
| </Switch> | ||
| <Route path="/:enterpriseSlug/*" element={<EnterpriseAppPageRoutes />} /> |
There was a problem hiding this comment.
Curious: why do we need to add the * at the end?
There was a problem hiding this comment.
Curious: why do we need to add the * at the end?
React Router V6 handles nested routes a little bit differently. So in order to match the descendent routes we have to add this *. [ref]
emrosarioa
reviewed
Oct 6, 2023
emrosarioa
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
React Router Upgrade to v6.
Description
This PR upgrades React Router from
v5tov6.