feat: upgraded to node v18, added .nvmrc and updated workflows #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #273 +/- ##
=======================================
Coverage 67.13% 67.13%
=======================================
Files 42 42
Lines 782 782
Branches 154 154
=======================================
Hits 525 525
Misses 249 249
Partials 8 8 ☔ View full report in Codecov by Sentry. |
added 3 commits
March 31, 2023 15:45
…ner-portal-programs into mashal-m/node-18-upgrade
jmbowman
added
the
needs maintainer attention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Upgrade Node JS from 16 to 18
edx-internal PR
https://github.com/edx/edx-internal/pull/8327
This needs to be merged together