-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: increase subsection grades rounding precision #1397
base: master
Are you sure you want to change the base?
fix: increase subsection grades rounding precision #1397
Conversation
We used two decimal digits to match the experience from the edx-platform. However, openedx/edx-platform#27788 increased the precision to reduce the impact of double rounding.
Thanks for the pull request, @Agrendalath! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1397 +/- ##
=======================================
Coverage 88.76% 88.76%
=======================================
Files 305 305
Lines 5234 5234
Branches 1327 1330 +3
=======================================
Hits 4646 4646
Misses 572 572
Partials 16 16 ☔ View full report in Codecov by Sentry. |
@Agrendalath Thank you for this contribution! It looks like the older PR that you mentioned in the description (openedx/edx-platform#27788) is tagged for product review. Should we do the same here? |
@Agrendalath OK great, I'll add the |
We used two decimal digits to match the experience from the edx-platform. However, openedx/edx-platform#27788 increased the precision to reduce the impact of double rounding.
See the details and testing instructions at openedx/edx-platform#27788.
Private-ref: BB-4210