Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase subsection grades rounding precision #1397

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Agrendalath
Copy link
Member

We used two decimal digits to match the experience from the edx-platform. However, openedx/edx-platform#27788 increased the precision to reduce the impact of double rounding.

See the details and testing instructions at openedx/edx-platform#27788.

Private-ref: BB-4210

We used two decimal digits to match the experience from the edx-platform.
However, openedx/edx-platform#27788 increased
the precision to reduce the impact of double rounding.
@openedx-webhooks
Copy link

Thanks for the pull request, @Agrendalath! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 26, 2024
Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.76%. Comparing base (e3ecee1) to head (12fffea).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1397   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files         305      305           
  Lines        5234     5234           
  Branches     1327     1330    +3     
=======================================
  Hits         4646     4646           
  Misses        572      572           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label May 31, 2024
@itsjeyd
Copy link

itsjeyd commented Jun 6, 2024

@Agrendalath Thank you for this contribution!

It looks like the older PR that you mentioned in the description (openedx/edx-platform#27788) is tagged for product review. Should we do the same here?

CC @mphilbrick211

@Agrendalath
Copy link
Member Author

@itsjeyd
Copy link

itsjeyd commented Jun 7, 2024

@Agrendalath OK great, I'll add the product review label now.

@itsjeyd itsjeyd added the product review PR requires product review before merging label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U product review PR requires product review before merging
Projects
Status: Product Review
Development

Successfully merging this pull request may close these issues.

None yet

3 participants