fix: save scroll position on exit from video xblock fullscreen mode

[ihor-romaniuk]

This merge request contains a fix for toggling video xblock full-screen mode and saving the previous window top offset position on exit from the full-screen state.

A related bug was found here https://bugs.chromium.org/p/chromium/issues/detail?id=142427 but it still reproduces.

Realised solution: Save the scroll position before the turn on the fullscreen mode and scroll to the previous position on turn off the fullscreen mode.

Dependent PR to MFE Learning:
This MR openedx/edx-platform#31053 must be merged with this MR.

[openedx-webhooks]

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (open-release/nutmeg.master@03e0f41). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@                      Coverage Diff                      @@
##             open-release/nutmeg.master     #981   +/-   ##
=============================================================
  Coverage                              ?   84.15%           
=============================================================
  Files                                 ?      258           
  Lines                                 ?     4455           
  Branches                              ?     1157           
=============================================================
  Hits                                  ?     3749           
  Misses                                ?      688           
  Partials                              ?       18           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[itsjeyd]

@ihor-romaniuk Thank you for your contribution! Please let us know when it is ready for review.

[ihor-romaniuk]

@itsjeyd It is ready for review. Thanks in advance.

[itsjeyd]

Thanks @ihor-romaniuk!

CC @mphilbrick211, this is ready for a status update.

[itsjeyd]

Hey @ihor-romaniuk, while this is waiting for review would you mind resolving the conflicts mentioned above? That way we can be sure that your changes will be up-to-date when reviewers start looking at them.

[ihor-romaniuk]

Hi @itsjeyd. The PR was updated and ready for review.

[itsjeyd]

Thanks @ihor-romaniuk! I updated the status of this PR accordingly.

@mattcarter This is ready for engineering review by the Aurora team (together with openedx/edx-platform#31053).

CC @mphilbrick211

[ProductRyan]

@ihor-romaniuk @itsjeyd - this appears to be the first of many PRs related to the same issue - I'd like to use this ticket as the primary communication place.

openedx/edx-platform#31055
openedx/edx-platform#31053
#982
#983
openedx/edx-platform#31061

Can you describe or show (video?) how the fix you are proposing works for a user? Specifically, I am looking for evidence that your change does not create any side effects that would add friction to the user experience.

[arbrandes]

This PR is not even the one to master. Does anybody mind if we move the general discussion to the issue I just created?

openedx/platform-roadmap#229

@ihor-romaniuk, do you mind replying there with the information @ProductRyan requested?

[itsjeyd]

@ihor-romaniuk Friendly reminder to follow up on @arbrandes's comment above.

[itsjeyd]

For reference, product review for this feature is happening via openedx/platform-roadmap#229.

[ihor-romaniuk]

Hi @itsjeyd @arbrandes
Answer was provided there openedx/platform-roadmap#229 with other additional information.

I'm waiting for review. Thanks.

[itsjeyd]

Thanks for the update, @ihor-romaniuk!

[ihor-romaniuk]

Hi @itsjeyd. Sorry for delay. Tests were updated and it's ready for review.

[itsjeyd]

Thanks @ihor-romaniuk, I posted on the main PR (#983) to get the changes lined up for engineering review.

[itsjeyd]

Note on current status: Main PR has been added to review queue.

[leangseu-edx]

LGTM 👍

[openedx-webhooks]

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.