Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block types with broken edit views #68

Closed
Tracked by #688 ...
brian-smith-tcril opened this issue Sep 26, 2022 · 13 comments
Closed
Tracked by #688 ...

Block types with broken edit views #68

brian-smith-tcril opened this issue Sep 26, 2022 · 13 comments
Assignees
Labels
enhancement Relates to new features or improvements to existing features

Comments

@brian-smith-tcril
Copy link
Contributor

brian-smith-tcril commented Sep 26, 2022

Some of the block types are not editable in the MFE (it's especially notable because of the 3 not in the "Advanced" dropdown, only 1 works)

Block Type Working? Error Message
Completion
Drag and Drop
Google Calendar
Google Document
Poll
Provide Feedback
Survey
Video TemplateDoesNotExist.zip
Word cloud NoSuchServiceError.zip
HTML Does not use new React-based editor
Advanced Problem TemplateDoesNotExist.zip

Proposed solution

The fix for the Video, HTML, and Problem blocks is to use the new React-based editors. These editors are currently only usable via the Course Authoring MFE. If the corresponding waffle flags are enabled (for instance new_core_editors.use_new_text_editor), when the user edits the corresponding block in Studio, they are sent to the Course Authoring MFE.

The Course Authoring MFE, in turn, imports the editors themselves from frontend-lib-content-components. As an MFE in its own right, the Library Authoring MFE should do the same.

@arbrandes
Copy link
Contributor

arbrandes commented Nov 7, 2022

Fixes for Video, Problem and HTML will likely come out of the new editors being developed for frontend-app-course-authoring. (The editors themselves are hosted in https://github.com/edx/frontend-lib-content-components/).

We'll just need to make sure Studio is configured to use the new editors, and that this MFE is using the correct endpoint to fetch them.

@jristau1984
Copy link
Contributor

@arbrandes is correct. Our rollout of the new Text/HTML editor for Course Authoring was automatically applied to the Library Authoring context as well. This is also true for the new Video Settings Editor which is currently in Beta testing.

I do not believe there will need to be anything special or unique done for these new editors to apply to the Library Authoring context.

Based on that, @brian-smith-tcril do you still want to keep this issue open?

@arbrandes
Copy link
Contributor

@jristau1984, @brian-smith-tcril, see the Proposed Solution in the ticket description. We're going to need to import and use the new editors in this MFE, just like Course Authoring does.

@arbrandes arbrandes added enhancement Relates to new features or improvements to existing features and removed bug Report of or fix for something that isn't working as intended labels Jan 27, 2023
@jristau1984
Copy link
Contributor

We are aware of this, and this integration work is part of the library authoring MFE rollout work that is currently being planned. We expect this to be completed in Q1 2023. Don't hesitate to reach out with any questions/comments/concerns. Thanks!

@arbrandes
Copy link
Contributor

@jristau1984, Any objections to us (as in @brian-smith-tcril) tackling this sooner rather than later? Is the work already in progress?

@jristau1984
Copy link
Contributor

jristau1984 commented Jan 27, 2023 via email

@brian-smith-tcril
Copy link
Contributor Author

Proposed solution

The fix for the Video, HTML, and Problem blocks is to use the new React-based editors.

@arbrandes
Copy link
Contributor

Yeah, see "Proposed Solution" above. Basically, to do here exactly what the Course Authoring MFE does: import the editors from frontend-lib-content-components. (As opposed to redirecting to the Course Authoring MFE.)

@jristau1984
Copy link
Contributor

Ahh, sorry I understand now you are proposing just the import portion of the work. That I have no issues with, but please coordinate with @connorhaugh as he is working on getting the library authoring MFE ready for beta test and I would prefer to not have duplicative updates.

More info:

  1. Yes, Editor overhauls are well on their way. Text and Video Settings Editors are rolled out in edx.org, and the Visual Problem Editor should begin a beta test within the next two weeks.
  2. For the Library Authoring MFE, since it is not rolled out in edx.org I personally have no issues with making this update. Additionally, since the current MFE does not have functioning editors this feels "just as safe" for any and all Open edX instances.

@connorhaugh
Copy link
Contributor

connorhaugh commented Jan 30, 2023

@arbrandes
A little more information. I will send you the set more fleshed-out set of tasks which solves the criteria "a user can CRUD problems, videos, and text components in the library authoring MFE using the new editors."
Those tasks roughly, are:

  • Fix "new problem xblock" button in Lib-authoring to match expected behavior
  • Replace existing edit page with new editors. (We'll want to flesh out a couple of design Q's here)
  • Reconcile static asset apis in new editors to match learning context.

@jristau1984
Copy link
Contributor

To close the loop for now, v2 editors in the Library Authoring MFE is being delivered by 2U and is tracked internally with this epic: https://2u-internal.atlassian.net/browse/TNL-10513.

This issue will likely remain open until that work is completed, please feel free to reach out to @jristau1984 with questions or other updates!

@arbrandes
Copy link
Contributor

If I'm not mistaken, this has now been solved, right?

@arbrandes
Copy link
Contributor

Closing it, as I believe the new editors all work, now. Feel free to reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Relates to new features or improvements to existing features
Projects
Status: Closed
Development

No branches or pull requests

4 participants