feat: add support for node 16 #395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
=======================================
Coverage 75.00% 75.00%
=======================================
Files 3 3
Lines 96 96
Branches 22 22
=======================================
Hits 72 72
Misses 19 19
Partials 5 5 Continue to review full report at Codecov.
|
- Replaced node-sass with sass - Replaced extract-text-webpack-plugin with mini-css-extract-plugin - Upgraded edx/paragon - Transform svg file in jest to fix tests
iamsobanjaved
force-pushed
the
iamsobanjaved/node-16-support
branch
from
338859c
to
26690a4
Compare
iamsobanjaved
commented
Mar 11, 2022
| @@ -102,6 +102,10 @@ | |||
| "jest": { | |||
| "testEnvironment": "jest-environment-jsdom-global", | |||
| "testURL": "http://localhost/", | |||
| "transform": { | |||
| "^.+\\.jsx?$": "babel-jest", | |||
| "^.+\\.svg$": "./src/svgTransform.js" | |||
There was a problem hiding this comment.
Introduced this to fix tests, from here: https://stackoverflow.com/a/59062195
binodpant
reviewed
Apr 4, 2022
| @@ -0,0 +1,9 @@ | |||
| module.exports = { | |||
| process() { | |||
There was a problem hiding this comment.
maybe worth a comment here on why this change?
binodpant
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-sasswithsassextract-text-webpack-pluginwithmini-css-extract-pluginedx/paragonTicket: BOM-3222