Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgraded to node v18, added .nvmrc and updated workflows #421

Merged
merged 3 commits into from
May 23, 2023

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Mar 16, 2023

Upgrade Node Js from 16 to 18

Description

  • Added support for node v18, updated .nvmrc and workflows.

@BilalQamar95 BilalQamar95 self-assigned this Mar 16, 2023
@BilalQamar95 BilalQamar95 marked this pull request as ready for review April 7, 2023 10:57
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (24874aa) 73.73% compared to head (5baf529) 73.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #421   +/-   ##
=======================================
  Coverage   73.73%   73.73%           
=======================================
  Files           3        3           
  Lines          99       99           
  Branches       29       29           
=======================================
  Hits           73       73           
  Misses         20       20           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arbrandes
Copy link
Contributor

@BilalQamar95, mind regenerating package-lock, please? Thanks!

@arbrandes arbrandes merged commit 5d2c9b3 into master May 23, 2023
5 checks passed
@arbrandes arbrandes deleted the bilalqamar95/node-v18-upgrade branch May 23, 2023 11:55
@edx-semantic-release
Copy link

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants