Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade frontend platform to version 3 #241

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

leangseu-edx
Copy link
Contributor

@leangseu-edx leangseu-edx commented Nov 2, 2022

BREAKING CHANGE:

  • No longer support @edx/frontend-platform@^2.0.0

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 81.25% // Head: 81.25% // No change to project coverage 👍

Coverage data is based on head (ec60b0c) compared to base (b06c8b5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #241   +/-   ##
=======================================
  Coverage   81.25%   81.25%           
=======================================
  Files           4        4           
  Lines          32       32           
  Branches        4        4           
=======================================
  Hits           26       26           
  Misses          6        6           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections (this component doesn't use caching explicitly), but can you please rebase on master and regenerate package-lock?

@leangseu-edx leangseu-edx force-pushed the leangseu-edx/upgrade-frontend-platform branch from 2e9fdfe to ec60b0c Compare November 9, 2022 14:26
@leangseu-edx
Copy link
Contributor Author

Update requested change

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@arbrandes arbrandes merged commit 159b5a8 into master Nov 10, 2022
@arbrandes arbrandes deleted the leangseu-edx/upgrade-frontend-platform branch November 10, 2022 11:08
@adamstankiewicz
Copy link
Member

@arbrandes @leangseu-edx Just a heads up, this PR could have been released as a non-breaking change if the peer dependency range denoted compatibility with v2 and v3 of @edx/frontend-platform (e.g., ^2.0.0 || ^3.0.0), which is true since this component doesn't use caching explicitly as @arbrandes identified earlier 😄

@leangseu-edx Also, reminder... if we make a change in this repository that is a breaking change for the component API or peer dependencies, an equivalent change should be made in our -footer-edx equivalent repository.

@adamstankiewicz
Copy link
Member

adamstankiewicz commented Nov 14, 2022

@leangseu-edx @arbrandes Also note, the PR description denoted this as a breaking change (which it was) but it wasn't actually released to NPM as a breaking change (only a new minor version was bumped)...

@arbrandes
Copy link
Contributor

@adamstankiewicz, any idea what the commit message missed? I was under the impression only a BREAKING CHANGE: in the body would be enough. Do we normally also need an exclamation point after the tag? (feat!:)?

@adamstankiewicz
Copy link
Member

@arbrandes BREAKING CHANGE: in the body should be all it requires, however, I don't think the commit that merged with master included the BREAKING CHANGE: in the commit body (it's only in the PR description).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants