-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade frontend platform to version 3 #241
Conversation
Codecov ReportBase: 81.25% // Head: 81.25% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #241 +/- ##
=======================================
Coverage 81.25% 81.25%
=======================================
Files 4 4
Lines 32 32
Branches 4 4
=======================================
Hits 26 26
Misses 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections (this component doesn't use caching explicitly), but can you please rebase on master and regenerate package-lock?
2e9fdfe
to
ec60b0c
Compare
Update requested change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
@arbrandes @leangseu-edx Just a heads up, this PR could have been released as a non-breaking change if the peer dependency range denoted compatibility with v2 and v3 of @leangseu-edx Also, reminder... if we make a change in this repository that is a breaking change for the component API or peer dependencies, an equivalent change should be made in our |
@leangseu-edx @arbrandes Also note, the PR description denoted this as a breaking change (which it was) but it wasn't actually released to NPM as a breaking change (only a new minor version was bumped)... |
@adamstankiewicz, any idea what the commit message missed? I was under the impression only a |
@arbrandes |
BREAKING CHANGE:
@edx/frontend-platform@^2.0.0