Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated frontend-build to bump jest version to v29 #369

Merged
merged 17 commits into from Apr 23, 2024

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jul 12, 2023

Description

  • Updated jest to v29 & frontend-build major version upgrade
  • Updated frontend-platform to v8

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.86%. Comparing base (45246ad) to head (a7fbdbe).

❗ Current head a7fbdbe differs from pull request most recent head 8b3f8ec. Consider uploading reports for the commit 8b3f8ec to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
- Coverage   70.67%   66.86%   -3.81%     
==========================================
  Files          24       24              
  Lines         358      338      -20     
  Branches       90       78      -12     
==========================================
- Hits          253      226      -27     
- Misses        103      110       +7     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 marked this pull request as ready for review April 22, 2024 13:21
@BilalQamar95 BilalQamar95 changed the title Updated frontend-build to bump jest version to v29 feat!: Updated frontend-build to bump jest version to v29 Apr 22, 2024
package.json Outdated
"react-responsive": "8.2.0",
"react-transition-group": "4.4.5"
},
"peerDependencies": {
"@edx/frontend-platform": "^7.0.0",
"@edx/frontend-platform": "^8.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@edx/frontend-platform": "^8.0.0",
"@edx/frontend-platform": "^7.0.0 || ^8.0.0",

i think we should add support of frontend-platform v7 here as well because a consumer will not break if it uses v7 or v8 of frontend-platform since frontend-platform v8 doesn't have any breaking changes except frontend-build peer dependency change. Moreover, we are opening PRs in respective MFEs as well with frontend-build and frontend-platform upgrade, i think we can handle this manually in those PRs. In this way we don't have to release it as a breaking change.

@BilalQamar95 BilalQamar95 changed the title feat!: Updated frontend-build to bump jest version to v29 feat: Updated frontend-build to bump jest version to v29 Apr 23, 2024
@BilalQamar95 BilalQamar95 merged commit 83c5b02 into master Apr 23, 2024
5 checks passed
@BilalQamar95 BilalQamar95 deleted the bilalqamar95/frontend-build-jest-upgrade branch April 23, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants