refactor: update test cases with Link

openedx · Aug 8, 2023 · 02931ab · 02931ab
1 parent c10a055
commit 02931ab
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 35 deletions.
diff --git a/packages/catalog-search/src/tests/LearningTypeRadioFacet.test.jsx b/packages/catalog-search/src/tests/LearningTypeRadioFacet.test.jsx
@@ -9,11 +9,9 @@ import LearningTypeRadioFacet from '../LearningTypeRadioFacet';
 import { features } from '../config';
 import { renderWithSearchContext } from './utils';
 
-const mockedNavigator = jest.fn();
-
 jest.mock('react-router-dom', () => ({
   ...jest.requireActual('react-router-dom'),
-  useNavigate: () => mockedNavigator,
+  useNavigate: () => jest.fn(),
   useLocation: () => ({
     pathname: '/',
   }),

diff --git a/packages/catalog-search/src/tests/SearchSuggestionItem.test.jsx b/packages/catalog-search/src/tests/SearchSuggestionItem.test.jsx
@@ -2,19 +2,9 @@ import { renderWithRouter } from '@edx/frontend-enterprise-utils';
 import React from 'react';
 import { screen } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
-import { Link } from 'react-router-dom';
 import SearchSuggestionItem from '../SearchSuggestionItem';
 
-jest.mock('react-router-dom', () => ({
-  ...jest.requireActual('react-router-dom'),
-  Link: jest.fn(({ to, onClick, children }) => <a href={to} className="suggestion-item" onClick={onClick}>{children}</a>),
-}));
-
 describe('<SeachSuggestionItem />', () => {
-  beforeEach(() => {
-    jest.clearAllMocks();
-  });
-
   test('renders course data', () => {
     const mockData = {
       course: {
@@ -96,10 +86,7 @@ describe('<SeachSuggestionItem />', () => {
       />,
     );
     userEvent.click(container.getElementsByClassName('suggestion-item')[0]);
-
-    expect(Link).toHaveBeenCalled();
-    const [[props]] = Link.mock.calls;
-    expect(props.to).toBe(mockData.program.url);
+    expect(window.location.pathname).toBe(mockData.program.url);
   });
 
   test('fires callback on click if disableSuggestionRedirect is true', () => {

diff --git a/packages/catalog-search/src/tests/SearchSuggestions.test.jsx b/packages/catalog-search/src/tests/SearchSuggestions.test.jsx
@@ -2,15 +2,9 @@ import { renderWithRouter } from '@edx/frontend-enterprise-utils';
 import React from 'react';
 import { screen } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
-import { Link } from 'react-router-dom';
 import SearchSuggestions from '../SearchSuggestions';
 import { COURSE_TYPE_EXECUTIVE_EDUCATION } from '../data/constants';
 
-jest.mock('react-router-dom', () => ({
-  ...jest.requireActual('react-router-dom'),
-  Link: jest.fn(({ to, children }) => <a href={to} className="suggestion-item">{children}</a>),
-}));
-
 const fakeSuggestionsData = {
   nbHits: 2,
   hits: [
@@ -64,10 +58,6 @@ const fakeSuggestionsDataEmptyAuthoringOrgs = {
 const handleSubmit = jest.fn();
 
 describe('<SeachSuggestions />', () => {
-  beforeEach(() => {
-    jest.clearAllMocks();
-  });
-
   test('renders all data', () => {
     renderWithRouter(<SearchSuggestions
       enterpriseSlug="test-enterprise"
@@ -119,10 +109,7 @@ describe('<SeachSuggestions />', () => {
     );
 
     userEvent.click(container.getElementsByClassName('suggestion-item')[0]);
-
-    expect(Link).toHaveBeenCalled();
-    const [props] = Link.mock.calls[0];
-    expect(props.to).toBe('/test-enterprise/course/edX+courseX');
+    expect(window.location.pathname).toBe('/test-enterprise/course/edX+courseX');
   });
 
   test('redirects to correct page on program click', () => {
@@ -132,10 +119,7 @@ describe('<SeachSuggestions />', () => {
       handleSubmit={handleSubmit}
     />);
     userEvent.click(container.getElementsByClassName('suggestion-item')[1]);
-
-    expect(Link).toHaveBeenCalled();
-    const [props] = Link.mock.calls[1];
-    expect(props.to).toBe('/test-enterprise/program/456');
+    expect(window.location.pathname).toBe('/test-enterprise/program/456');
   });
   test('properly handles exec ed content', () => {
     const { container } = renderWithRouter(<SearchSuggestions