fix: useNavigate being undefined

openedx · Jul 12, 2023 · cd8c8b0 · cd8c8b0
1 parent 389962f
commit cd8c8b0
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 75 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -29,8 +29,6 @@ jobs:
       run: |
         echo "//registry.npmjs.org/:_authToken=${{ secrets.SEMANTIC_RELEASE_NPM_TOKEN }}" >> .npmrc
         npm whoami
-    - name: Clean NPM
-      run: npm run clean
     - name: Install and Setup Dependencies
       run: npm ci
     # build must come before running linting and tests for the `dist` directory to exist.

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/catalog-search/src/tests/FacetListBase.test.jsx b/packages/catalog-search/src/tests/FacetListBase.test.jsx
@@ -3,7 +3,6 @@ import { renderWithRouter } from '@edx/frontend-enterprise-utils';
 import { act, screen, fireEvent } from '@testing-library/react';
 import '@testing-library/jest-dom/extend-expect';
 
-import { BrowserRouter } from 'react-router-dom';
 import { FREE_ALL_TITLE } from '../SearchFilters';
 import FacetListBase from '../FacetListBase';
 import { FACET_ATTRIBUTES, SUBJECTS } from '../data/tests/constants';
@@ -55,7 +54,7 @@ const searchableDropdownProps = {
 
 describe('<FacetListBase />', () => {
   test('renders with no options', async () => {
-    renderWithRouter(<BrowserRouter><SearchData><FacetListBase {...propsForNoItems} /></SearchData></BrowserRouter>);
+    renderWithRouter(<SearchData><FacetListBase {...propsForNoItems} /></SearchData>);
 
     // assert facet title exists
     expect(screen.queryByText(FREE_ALL_TITLE)).toBeInTheDocument();

diff --git a/packages/catalog-search/src/tests/SearchFilters.test.jsx b/packages/catalog-search/src/tests/SearchFilters.test.jsx
@@ -9,13 +9,6 @@ import { renderWithSearchContext } from './utils';
 import '../../__mocks__/react-instantsearch-dom';
 import SearchFilters from '../SearchFilters';
 
-const mockedNavigator = jest.fn();
-
-jest.mock('react-router-dom', () => ({
-  ...jest.requireActual('react-router-dom'),
-  useNavigate: () => mockedNavigator,
-}));
-
 const SearchContextWrapper = () => {
   const contextValue = useMemo(() => ({ width: breakpoints.large.maxWidth }), []);
   return (