Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-7171: Updated course link for executive education courses. #336

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

saleem-latif
Copy link
Contributor

@saleem-latif saleem-latif commented Jun 5, 2023

Jira Ticket: ENT-7171

Description:
Executive Education redirects should point towards the learner portal when supported.

Acceptance Criteria:

  1. address this todo within the frontend-enterprise utils package to allow for executive education suggested search to redirect to the enterprise learner portal.

Note that this will require updating the executive education section of the component’s usage of getLinkToCourse to account for the executive-education-2u/course/<course_key> learner portal route.

Merge checklist:

  • Evaluate how your changes will impact existing consumers (e.g., frontend-app-learner-portal-enterprise, frontend-app-admin-portal, and frontend-app-enterprise-public-catalog). Will consumers safely be able to upgrade to this change without any breaking changes?
  • Ensure your commit message follows the semantic-release conventional commit message format. If your changes include a breaking change, ensure your commit message is explicitly marked as a BREAKING CHANGE so the NPM package is released as such.
  • Once CI is passing, verify the package versions that Lerna will increment to in the Github Action CI workflow logs.
    • Note: This may be found in the "Preview Updated Versions (dry run)" step in the Github Action CI workflow logs.

Post merge:

  • Verify Lerna created a release commit (e.g., chore(release): publish) that incremented versions in relevant package.json and CHANGELOG files, and created Git tags for those versions.
  • Run the Publish from package.json Github Action workflow to publish these new package versions to NPM.
    • This may be triggered by clicking the "Run workflow" option for the master branch.
  • Verify the new package versions were published to NPM (i.e., npm view <package_name> versions --json).
    • Note: There may be a slight delay between when the workflow finished and when NPM reports the package version as being published. If it doesn't appear right away in the above command, try again in a few minutes.

@saleem-latif saleem-latif self-assigned this Jun 5, 2023
@saleem-latif saleem-latif changed the title ENT-7171: Updated course link for executive4 education courses. WIP -- ENT-7171: Updated course link for executive4 education courses. Jun 5, 2023
@saleem-latif saleem-latif changed the title WIP -- ENT-7171: Updated course link for executive4 education courses. ENT-7171: Updated course link for executive4 education courses. Jun 5, 2023
@saleem-latif saleem-latif force-pushed the saleem-latif/ENT-7171 branch 2 times, most recently from 9f36dfd to 73e76bb Compare June 5, 2023 10:53
@saleem-latif saleem-latif changed the title ENT-7171: Updated course link for executive4 education courses. ENT-7171: Updated course link for executive education courses. Jun 5, 2023
Copy link

@bilaltahir21 bilaltahir21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 👍

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #336 (9029993) into master (d87f5dd) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   78.06%   78.26%   +0.19%     
==========================================
  Files          34       34              
  Lines         661      667       +6     
  Branches      171      172       +1     
==========================================
+ Hits          516      522       +6     
  Misses        132      132              
  Partials       13       13              
Impacted Files Coverage Δ
packages/catalog-search/src/SearchSuggestions.jsx 100.00% <100.00%> (ø)
packages/catalog-search/src/data/constants.js 92.59% <100.00%> (+0.59%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d87f5dd...9029993. Read the comment docs.

@saleem-latif saleem-latif merged commit 4212580 into master Jun 6, 2023
@saleem-latif saleem-latif deleted the saleem-latif/ENT-7171 branch June 6, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants