-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENT-7171: Updated course link for executive education courses. #336
Conversation
263a6ad
to
30bde53
Compare
9f36dfd
to
73e76bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good 👍
73e76bb
to
9029993
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #336 +/- ##
==========================================
+ Coverage 78.06% 78.26% +0.19%
==========================================
Files 34 34
Lines 661 667 +6
Branches 171 172 +1
==========================================
+ Hits 516 522 +6
Misses 132 132
Partials 13 13
Continue to review full report in Codecov by Sentry.
|
Jira Ticket: ENT-7171
Description:
Executive Education redirects should point towards the learner portal when supported.
Acceptance Criteria:
Note that this will require updating the executive education section of the component’s usage of getLinkToCourse to account for the
executive-education-2u/course/<course_key>
learner portal route.Merge checklist:
frontend-app-learner-portal-enterprise
,frontend-app-admin-portal
, andfrontend-app-enterprise-public-catalog
). Will consumers safely be able to upgrade to this change without any breaking changes?BREAKING CHANGE
so the NPM package is released as such.Post merge:
chore(release): publish
) that incremented versions in relevant package.json and CHANGELOG files, and created Git tags for those versions.Publish from package.json
Github Action workflow to publish these new package versions to NPM.master
branch.npm view <package_name> versions --json
).