Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sendEnterpriseTrackEventWithDelay #272

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

long74100
Copy link
Contributor

Merge checklist:

  • Evaluate how your changes will impact existing consumers (e.g., frontend-app-learner-portal-enterprise, frontend-app-admin-portal, and frontend-app-enterprise-public-catalog). Will consumers safely be able to upgrade to this change without any breaking changes?
  • Ensure your commit message follows the semantic-release conventional commit message format. If your changes include a breaking change, ensure your commit message is explicitly marked as a BREAKING CHANGE so the NPM package is released as such.
  • Once CI is passing, verify the package versions that Lerna will increment to in the Github Action CI workflow logs.
    • Note: This may be found in the "Preview Updated Versions (dry run)" step in the Github Action CI workflow logs.

Post merge:

  • Verify Lerna created a release commit (e.g., chore(release): publish) that incremented versions in relevant package.json and CHANGELOG files, and created Git tags for those versions.
  • Run the Publish from package.json Github Action workflow to publish these new package versions to NPM.
    • This may be triggered by clicking the "Run workflow" option for the master branch.
  • Verify the new package versions were published to NPM (i.e., npm view <package_name> versions --json).
    • Note: There may be a slight delay between when the workflow finished and when NPM reports the package version as being published. If it doesn't appear right away in the above command, try again in a few minutes.

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #272 (f95d49c) into master (2d03231) will increase coverage by 0.08%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
+ Coverage   77.51%   77.60%   +0.08%     
==========================================
  Files          34       34              
  Lines         645      652       +7     
  Branches      161      163       +2     
==========================================
+ Hits          500      506       +6     
- Misses        132      133       +1     
  Partials       13       13              
Impacted Files Coverage Δ
packages/utils/src/analytics.js 88.88% <87.50%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d03231...f95d49c. Read the comment docs.

packages/utils/src/analytics.js Outdated Show resolved Hide resolved
packages/utils/src/tests/analytics.test.js Show resolved Hide resolved
@long74100 long74100 force-pushed the llin/send-track-event-with-delay branch from a333a53 to c6654b5 Compare August 24, 2022 15:50
@long74100 long74100 force-pushed the llin/send-track-event-with-delay branch from c6654b5 to f95d49c Compare August 24, 2022 15:53
@long74100 long74100 merged commit 97879ea into master Aug 24, 2022
@long74100 long74100 deleted the llin/send-track-event-with-delay branch August 24, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants