fix: only apply bg-brand-primary to SearchHeader if variant=inverse #281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue where there is incorrectly a background color on the
SearchHeader
component used across 3 MFEs.Screenshots
Before (Bulk Enrollment)
After (Bulk Enrollment)
More details
bg-brand-primary
class that was already on theSearchHeader
component began to apply a style change once that class name had meaning within the admin portal MFE.inverse
variant and actually do want the background to be the enterprise's theme color. To keep support for learner portal, but fix for the other MFEs, thebg-brand-primary
class will only be applied whenvariant="inverse"
, which is only true for the learner portal.Merge checklist:
frontend-app-learner-portal-enterprise
,frontend-app-admin-portal
, andfrontend-app-enterprise-public-catalog
). Will consumers safely be able to upgrade to this change without any breaking changes?BREAKING CHANGE
so the NPM package is released as such.Post merge:
chore(release): publish
) that incremented versions in relevant package.json and CHANGELOG files, and created Git tags for those versions.Publish from package.json
Github Action workflow to publish these new package versions to NPM.master
branch.npm view <package_name> versions --json
).