Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: move paragon to peer dependency using @openedx scope #367

Merged
merged 7 commits into from Feb 12, 2024

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Dec 29, 2023

Description

Part of openedx/axim-engineering#23

This replaces the @edx/paragon and @edx/frontend-build package.
Imports have been updated to use the same locations in the new package.

BREAKING CHANGE: consuming applications must now provide paragon from the @openedx scope

Merge checklist:

  • Evaluate how your changes will impact existing consumers (e.g., frontend-app-learner-portal-enterprise, frontend-app-admin-portal, and frontend-app-enterprise-public-catalog). Will consumers safely be able to upgrade to this change without any breaking changes?
  • Ensure your commit message follows the semantic-release conventional commit message format. If your changes include a breaking change, ensure your commit message is explicitly marked as a BREAKING CHANGE so the NPM package is released as such.
  • Once CI is passing, verify the package versions that Lerna will increment to in the Github Action CI workflow logs.
    • Note: This may be found in the "Preview Updated Versions (dry run)" step in the Github Action CI workflow logs.

Post merge:

  • Verify Lerna created a release commit (e.g., chore(release): publish) that incremented versions in relevant package.json and CHANGELOG files, and created Git tags for those versions.
  • Run the Publish from package.json Github Action workflow to publish these new package versions to NPM.
    • This may be triggered by clicking the "Run workflow" option for the master branch.
  • Verify the new package versions were published to NPM (i.e., npm view <package_name> versions --json).
    • Note: There may be a slight delay between when the workflow finished and when NPM reports the package version as being published. If it doesn't appear right away in the above command, try again in a few minutes.

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (44ebd0f) 78.61% compared to head (7c07a71) 78.61%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #367   +/-   ##
=======================================
  Coverage   78.61%   78.61%           
=======================================
  Files          34       34           
  Lines         692      692           
  Branches      179      179           
=======================================
  Hits          544      544           
  Misses        135      135           
  Partials       13       13           
Files Coverage Δ
...ges/catalog-search/src/ClearCurrentRefinements.jsx 100.00% <ø> (ø)
packages/catalog-search/src/CurrentRefinements.jsx 78.94% <ø> (ø)
packages/catalog-search/src/FacetDropdown.jsx 100.00% <ø> (ø)
packages/catalog-search/src/FacetItem.jsx 100.00% <ø> (ø)
...ages/catalog-search/src/LearningTypeRadioFacet.jsx 90.00% <ø> (ø)
packages/catalog-search/src/MobileFilterMenu.jsx 86.66% <ø> (ø)
packages/catalog-search/src/SearchBox.jsx 88.88% <ø> (ø)
packages/catalog-search/src/SearchFilters.jsx 75.00% <ø> (ø)
packages/catalog-search/src/SearchHeader.jsx 92.30% <ø> (ø)
packages/catalog-search/src/SearchPagination.jsx 100.00% <ø> (ø)
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6eb23b...7c07a71. Read the comment docs.

@abdullahwaheed abdullahwaheed changed the title refactor: replace @edx/paragon and @edx/frontend-build feat: replaced scope of @edx/paragon and @edx/frontend-build to @openedx/paragon and @openedx/frontend-build respectively Feb 7, 2024
@abdullahwaheed abdullahwaheed marked this pull request as ready for review February 12, 2024 13:12
@abdullahwaheed abdullahwaheed changed the title feat: replaced scope of @edx/paragon and @edx/frontend-build to @openedx/paragon and @openedx/frontend-build respectively chore!: move paragon to peer dependency using @openedx scope Feb 12, 2024
@abdullahwaheed abdullahwaheed merged commit d121d67 into master Feb 12, 2024
10 checks passed
@abdullahwaheed abdullahwaheed deleted the mashal-m/replace-edx/paragon-frontend-build branch February 12, 2024 14:02
@BilalQamar95 BilalQamar95 self-assigned this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants