Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend-lib-content-components] Localization issues #385

Open
Tracked by #16
arbrandes opened this issue Sep 7, 2023 · 2 comments
Open
Tracked by #16

[frontend-lib-content-components] Localization issues #385

arbrandes opened this issue Sep 7, 2023 · 2 comments
Labels
bug Report of or fix for something that isn't working as intended

Comments

@arbrandes
Copy link

arbrandes commented Sep 7, 2023

Description

(This has a sister issue, openedx/frontend-app-communications#148, and both are being tackled simultaneously via openedx/wg-translations#16.)

As first noted on Slack 2023-08-15 by @sambapete, it seems when previewing the type of problems some strings may not be properly identified for translations.

For instance, in https://github.com/openedx/frontend-lib-content-components/blob/main/src/editors/data/constants/problem.js, there are no indications that "Specify one or more correct numeric answers, submitted in a response field." would be translated.

There is also no corresponding section in Transifex.

(Side bug: all "Learn more" links point edx.readthedocs.io.)

Solution space

The owning team has been contacted via one of the project's wiki pages.

This repository is also up for inclusion in the Atlas (aka OEP-58) pilot (as is frontend-app-communications) , as opposed to pursuing the usual edx-transifex-bot route.

@arbrandes arbrandes added the bug Report of or fix for something that isn't working as intended label Sep 7, 2023
@arbrandes arbrandes self-assigned this Sep 7, 2023
@OmarIthawi OmarIthawi self-assigned this Jan 17, 2024
@OmarIthawi
Copy link
Member

This issue has been fixed as far as the Communications MFE is concerned. The solution has been done by adding an atlas pull argument to the Makefile building step:

Some strings may not make it and needs to be marked correctly as formattedMessage like I've mentioned in my previous #385 (comment).

This repository still needs the formattedMessage calls.

cc: @ehuthmacher @arbrandes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended
Projects
Status: Backlog
Development

No branches or pull requests

2 participants