Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade react router to v6 #90

Merged
merged 7 commits into from
Sep 12, 2023
Merged

Conversation

Syed-Ali-Abbas-Zaidi
Copy link
Contributor

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi commented Mar 16, 2023

Ticket

React Router Upgrade to v6.

Description

This PR upgrades React Router from v5 to v6.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi marked this pull request as draft March 16, 2023 06:22
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi self-assigned this Mar 16, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9ac3d78) 94.12% compared to head (d3babca) 94.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   94.12%   94.12%           
=======================================
  Files          71       71           
  Lines        1055     1055           
  Branches      289      289           
=======================================
  Hits          993      993           
  Misses         57       57           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi marked this pull request as ready for review August 8, 2023 07:16
@ilee2u
Copy link
Contributor

ilee2u commented Sep 12, 2023

Tested locally, the timed exam UI flow seems to run perfectly fine. Also there does not seem to be any react-dom-router based components that we'd need to refactor based on their doc's migration notes. Merging now.

@ilee2u ilee2u merged commit d09716c into main Sep 12, 2023
7 checks passed
@ilee2u ilee2u deleted the Ali-Abbas/react-router-upgrade branch September 12, 2023 17:44
@github-actions
Copy link

🎉 This PR is included in version 2.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants