Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Import new taxonomy dialog flow #1017

Merged
merged 5 commits into from
May 24, 2024
Merged

feat: Import new taxonomy dialog flow #1017

merged 5 commits into from
May 24, 2024

Conversation

yusuf-musleh
Copy link
Contributor

@yusuf-musleh yusuf-musleh commented May 19, 2024 •
edited
Loading

Description

This PR utilizes the existing import tags wizard that updates taxonomies for importing new taxonomies as well.

import-new-taxonomy

Supporting information

Related Tickets:

Testing instructions

  1. Run this branch in your local devstack/tutor
  2. Navigate to the taxonomies page
  3. Click on import and should see the new dialog appear
  4. Confirm that you can download the json/csv templates from the new dialog
  5. Confirm that you can go through the whole flow successfully
  6. Then click the 3-dots action menu for any existing taxonomy
  7. Click on "Re-import"
  8. You'll also see a slightly different (the original) dialog flow specifically for updating a taxonomy
  9. Confirm that it is still working properly

Private-ref: FAL-3725

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 19, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented May 19, 2024 •
edited
Loading

Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/import-new-taxonomy-dialog-flow branch 2 times, most recently from f448635 to a0ae3bc Compare May 20, 2024 11:58
@codecov Codecov
Copy link

codecov bot commented May 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.43%. Comparing base (7247cc2) to head (6828536).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1017      +/-   ##
==========================================
+ Coverage   92.40%   92.43%   +0.02%     
==========================================
  Files         708      708              
  Lines       12523    12565      +42     
  Branches     2702     2760      +58     
==========================================
+ Hits        11572    11614      +42     
  Misses        914      914              
  Partials       37       37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/import-new-taxonomy-dialog-flow branch 3 times, most recently from e59343a to ff1ac49 Compare May 20, 2024 16:18
@yusuf-musleh yusuf-musleh marked this pull request as ready for review May 20, 2024 19:46
@yusuf-musleh yusuf-musleh requested a review from a team as a code owner May 20, 2024 19:46
pomegranited
pomegranited approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great refactor @yusuf-musleh ! It works perfectly and looks good.

There's just a couple strings missing from messages, and one minor nit, but this will be ready for upstream review once they're addressed.

👍

  • I tested this using the PR test instructions
  • I read through the code
  • I checked for accessibility issues by using my keyboard to navigate while testing.
  • Includes documentation N/A
  • User-facing strings are extracted for translation -- see inline note

src/taxonomy/import-tags/ImportTagsWizard.jsx Outdated Show resolved Hide resolved
src/taxonomy/import-tags/ImportTagsWizard.jsx Outdated Show resolved Hide resolved
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/import-new-taxonomy-dialog-flow branch from cddd653 to a57fda0 Compare May 21, 2024 14:22
xitij2000
xitij2000 approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@xitij2000 xitij2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one small nit.

src/taxonomy/import-tags/ImportTagsWizard.jsx Outdated Show resolved Hide resolved
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/import-new-taxonomy-dialog-flow branch from a57fda0 to 6828536 Compare May 24, 2024 07:39
@yusuf-musleh
Copy link
Contributor Author

@xitij2000 It should be good to go for merge

@xitij2000 xitij2000 merged commit d0b3328 into openedx:master May 24, 2024
5 checks passed
@openedx-webhooks
Copy link

@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@xitij2000 xitij2000 deleted the yusuf-musleh/import-new-taxonomy-dialog-flow branch May 24, 2024 13:49
yusuf-musleh added a commit to open-craft/frontend-app-authoring that referenced this pull request May 26, 2024
@yusuf-musleh
feat: Import new taxonomy dialog flow (openedx#1017)
c35e731 
This PR updates the existing import tags wizard to also handle  importing new taxonomies.
@yusuf-musleh yusuf-musleh mentioned this pull request May 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xitij2000 xitij2000 xitij2000 approved these changes

@pomegranited pomegranited pomegranited approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display a dialog for the "Import" workflow
4 participants
@yusuf-musleh @openedx-webhooks @xitij2000 @pomegranited