Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually upgrade pip-tools to 6.5.0 to fix pip/pip-tools bug. #218

Merged
merged 1 commit into from Feb 8, 2022

Conversation

doctoryes
Copy link
Contributor

This failure started happening in the automated requirements upgrade:
https://github.com/openedx/XBlock/runs/5100983778?check_suite_focus=true

The bug was being caused by an interaction between pip and pip-tools, described here:
jazzband/pip-tools#1558

The bug is fixed in pip-tools==6.5.0 - from this PR:
jazzband/pip-tools#1567

Just bump the version manually to get the automated upgrades working again.

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #218 (d029aee) into master (b08bc63) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage   93.96%   94.03%   +0.07%     
==========================================
  Files          29       29              
  Lines        2833     2833              
  Branches      292      292              
==========================================
+ Hits         2662     2664       +2     
+ Misses        146      145       -1     
+ Partials       25       24       -1     
Flag Coverage Δ
unittests 94.03% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
opaque_keys/edx/locator.py 92.38% <0.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b08bc63...d029aee. Read the comment docs.

@doctoryes doctoryes merged commit 2ee89b9 into master Feb 8, 2022
@doctoryes doctoryes deleted the juliasq/fix_pip_tools_for_pkg_upgrade branch February 8, 2022 15:17
MichaelRoytman added a commit to openedx/edx-submissions that referenced this pull request Mar 29, 2022
The following comment is borrowed from this pull request, with changes: openedx/opaque-keys#218

This failure started happening in the automated requirements upgrade GitHub action:
https://github.com/openedx/edx-submissions/runs/5704384647?check_suite_focus=true

The bug was being caused by an interaction between pip and pip-tools, described here:
jazzband/pip-tools#1558

The bug is fixed in pip-tools==6.5.0 - from this PR:
jazzband/pip-tools#1567

This pull requests bumps the version of pip-tools manually to get the automated upgrades working again.
MichaelRoytman added a commit to openedx/edx-submissions that referenced this pull request Mar 29, 2022
The following comment is borrowed from this pull request, with changes: openedx/opaque-keys#218

This failure started happening in the automated requirements upgrade GitHub action:
https://github.com/openedx/edx-submissions/runs/5704384647?check_suite_focus=true

The bug was being caused by an interaction between pip and pip-tools, described here: jazzband/pip-tools#1558

The bug is fixed in pip-tools==6.5.0 - from this pull request: jazzband/pip-tools#1567

This pull requests bumps the version of pip-tools manually to get the automated upgrades working again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants