Draft OEP-34: Lint Amnesty #108
Conversation
| -------- | ||
|
|
||
| In all repositories, we will grant amnesty to all existing linting violations. | ||
| This includes pylint, xsslint, pycodestyle, and any other linting programs |
There was a problem hiding this comment.
Generally love the idea, but I have some hesitation around xsslint, especially when it comes to repos that haven't yet employed it.
There was a problem hiding this comment.
I guess my feeling is that adding the ignores is no worse (and probably better) than having cap on the number. Either way, the issues aren't being immediately fixed, and I think flagging them in the code makes them more visible.
There was a problem hiding this comment.
The xsslint issues are being fixed. I'd still recommend not listing this, but I'll leave that to the security team to determine.
There was a problem hiding this comment.
@feanil: It looks like this got merged, but I still propose that xsslint gets dropped from this list.
Co-Authored-By: cpennington <calen.pennington@gmail.com>
The amnesty tool has been in heavy use so I think it's safe to say it's not just a prototype anymore.
|
This is a great step forward for the Open edX codebase. Among other benefits it will make life much easier for first time-contributors. |
Accepted the oep after a complete review process and discussions.
No description provided.