Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update OEP-15 to match current implementation #396

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

xitij2000
Copy link
Contributor

There were differences between the approach described in OEP-15 and the final
implemntation in edx-platform#28411. This commit updated the OEP to match the
latest implementation.

There were differences between the approach described in OEP-15 and the final
implemntation in edx-platform#28411. This commit updated the OEP to match the
latest implementation.
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 7, 2022

Thanks for the pull request, @xitij2000! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

@pkulkark pkulkark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the small suggestion, otherwise LGTM 👍

…-js.rst

Co-authored-by: Pooja Kulkarni <13742492+pkulkark@users.noreply.github.com>
@xitij2000 xitij2000 marked this pull request as ready for review October 12, 2022 07:20
@itsjeyd
Copy link

itsjeyd commented Nov 15, 2022

Hi @jmbowman, this PR is ready for review. Would you have time to take a look?

@itsjeyd
Copy link

itsjeyd commented Dec 6, 2022

@jmbowman A friendly nudge regarding the previous comment.

If you'd prefer that I ping someone else for review here, please let me know.

CC @mphilbrick211

@itsjeyd
Copy link

itsjeyd commented Dec 15, 2022

Alternatively, @scottrish maybe you could have a look at this PR, as arbiter of the original OEP-15?

CC @mphilbrick211

@ormsbee ormsbee self-requested a review December 21, 2022 18:50
@rgraber
Copy link
Contributor

rgraber commented Jan 10, 2023

Assigning to me for tracking purposes.
@ormsbee do you still want to review this or should I take it?

@rgraber rgraber self-assigned this Jan 10, 2023
@ormsbee
Copy link

ormsbee commented Jan 11, 2023

@rgraber: Sorry, I forgot about this one over the break. Feel free to take it, but I think it's also fine to just squash+merge as is. I would ideally like a little changelog entry explaining the reason this changed, but given that the OEP was never accurate, I don't feel strongly about it.

Copy link
Contributor

@rgraber rgraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgraber rgraber merged commit 8b2aedd into master Jan 11, 2023
@rgraber rgraber deleted the kshitij/update-oep-15 branch January 11, 2023 13:11
@openedx-webhooks
Copy link

@xitij2000 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants