-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update OEP-15 to match current implementation #396
Conversation
There were differences between the approach described in OEP-15 and the final implemntation in edx-platform#28411. This commit updated the OEP to match the latest implementation.
Thanks for the pull request, @xitij2000! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the small suggestion, otherwise LGTM 👍
…-js.rst Co-authored-by: Pooja Kulkarni <13742492+pkulkark@users.noreply.github.com>
Hi @jmbowman, this PR is ready for review. Would you have time to take a look? |
@jmbowman A friendly nudge regarding the previous comment. If you'd prefer that I ping someone else for review here, please let me know. |
Alternatively, @scottrish maybe you could have a look at this PR, as arbiter of the original OEP-15? |
Assigning to me for tracking purposes. |
@rgraber: Sorry, I forgot about this one over the break. Feel free to take it, but I think it's also fine to just squash+merge as is. I would ideally like a little changelog entry explaining the reason this changed, but given that the OEP was never accurate, I don't feel strongly about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@xitij2000 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
There were differences between the approach described in OEP-15 and the final
implemntation in edx-platform#28411. This commit updated the OEP to match the
latest implementation.