Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updating OEP-65 filename and adding link to merge discussion #585

Merged
merged 2 commits into from May 13, 2024

Conversation

davidjoy
Copy link
Contributor

  • Adds "arch-" to OEP-65's filename
  • Adds a link to the slack discussion in #open-edx-proposals where we decided to merge the OEP as provisional.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 13, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @davidjoy! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@sarina
Copy link
Contributor

sarina commented May 13, 2024

Ah yeah @davidjoy I remember why I wanted you to just close the PR and open a new one. The failing check is because you moved a file and now have to set up a redirect.

@davidjoy
Copy link
Contributor Author

Ugh! Done. Hopefully that fixes it.

@sarina sarina merged commit 608c53d into openedx:master May 13, 2024
5 checks passed
@openedx-webhooks
Copy link

@davidjoy 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@davidjoy davidjoy deleted the djoy/update-oep-65-filename branch May 13, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants