Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update timezone language #18

Merged
merged 5 commits into from
Dec 14, 2016
Merged

Update timezone language #18

merged 5 commits into from
Dec 14, 2016

Conversation

efischer19
Copy link
Contributor

TNL-6051

@catong and @yro to review, when you have a chance.

We actually use timezones now!

TNL-6051
@efischer19
Copy link
Contributor Author

Screenshot of previous wording, from my devstack:
screen shot 2016-12-14 at 12 50 45 pm

@@ -2,7 +2,7 @@
<p>Most courses have interactive questions that test your knowledge like the one below. They can be part of a learning sequence or an exam. Notice the visual feedback. Go ahead, try it out!</p>
<p>Questions which are part of assignments or exams may have due dates - the last possible time you can submit an assignment for grading. Once this time has passed, you will not be able to get credit for any incomplete problems in the assignment.</p>
<p>If an assignment has a due date, you can see the due date in the accordion on the side. (This demo course does not have any due date.) If no due date is displayed, the assignment can be turned in at any time.</p>
<p>All assignment due dates are listed in UTC (the international time standard). Please <a href="http://www.timeanddate.com/worldclock/">look up your time zone</a> in order to understand what time your assignments are due according to your clock. EdX cannot offer any extensions.</p>
<p>All assignment due dates are listed in the user's specified timezone, defaulting to UTC (the international time standard) if one has not been chosen. EdX cannot offer any extensions.</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efischer19 @yro Is it still true that the assignment dates will default to UTC if a user has not specified a time zone? I thought browser time zone would be used for assignment dates if a time zone wasn't set in account settings.

@@ -2,7 +2,7 @@
<p>Most courses have interactive questions that test your knowledge like the one below. They can be part of a learning sequence or an exam. Notice the visual feedback. Go ahead, try it out!</p>
<p>Questions which are part of assignments or exams may have due dates - the last possible time you can submit an assignment for grading. Once this time has passed, you will not be able to get credit for any incomplete problems in the assignment.</p>
<p>If an assignment has a due date, you can see the due date in the accordion on the side. (This demo course does not have any due date.) If no due date is displayed, the assignment can be turned in at any time.</p>
<p>All assignment due dates are listed in UTC (the international time standard). Please <a href="http://www.timeanddate.com/worldclock/">look up your time zone</a> in order to understand what time your assignments are due according to your clock. EdX cannot offer any extensions.</p>
<p>All assignment due dates are listed in the user's specified timezone, defaulting to UTC (the international time standard) if one has not been chosen. EdX cannot offer any extensions.</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efischer19 If you don't mind, can we also make a couple of changes to the paragraph previous to the one where time zone is mentioned.
"...you can see the due date in the accordion on the side" -> "you can see the due date in the sidebar."
"This demo course does not have any due date." -> "This demo course does not have any assignments with due dates."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely, that's why I tagged our neighborhood doc expert 😃

New commit incoming...

<p>If an assignment has a due date, you can see the due date in the accordion on the side. (This demo course does not have any due date.) If no due date is displayed, the assignment can be turned in at any time.</p>
<p>All assignment due dates are listed in UTC (the international time standard). Please <a href="http://www.timeanddate.com/worldclock/">look up your time zone</a> in order to understand what time your assignments are due according to your clock. EdX cannot offer any extensions.</p>
<p>If an assignment has a due date, you can see the due date in the sidebar. (This demo course does not have any assignments with due dates.) If no due date is displayed, the assignment can be turned in at any time.</p>
<p>All assignment due dates are listed in the user's specified timezone, defaulting to UTC (the international time standard) if one has not been chosen. EdX cannot offer any extensions.</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will attempt to determine the user's system timezone, and failing that, will revert to UTC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, so how does the user's preference-selected timezone figure into that?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused too. Does user's "system timezone" = their account specified timezone or their browser timezone?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, it goes, in order of preference user preference -> system timezone -> UTC. (you can maybe leave out UTC, that's really just a 'nothing worked, so we're bailing out' handler).

Copy link

@catong catong Dec 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efischer19 How about this:
"All assignment due dates are displayed in the time zone that you select in your account settings. If you do not specify a time zone, assignment due dates display in your browser's time zone."
Also, I'm in favor of dropping the last sentence re extensions. It seems out of place here.

@efischer19
Copy link
Contributor Author

New screenshot, includes @catong's updates but the resolution of the system time vs account specified time vs UTC discussion is not here.

screen shot 2016-12-14 at 1 19 48 pm

<p>If an assignment has a due date, you can see the due date in the accordion on the side. (This demo course does not have any due date.) If no due date is displayed, the assignment can be turned in at any time.</p>
<p>All assignment due dates are listed in UTC (the international time standard). Please <a href="http://www.timeanddate.com/worldclock/">look up your time zone</a> in order to understand what time your assignments are due according to your clock. EdX cannot offer any extensions.</p>
<p>If an assignment has a due date, you can see the due date in the sidebar. (This demo course does not have any assignments with due dates.) If no due date is displayed, the assignment can be turned in at any time.</p>
<p>All assignment due dates are listed in the user's preferred timezone, defaulting to the user's browser defined timezone if one has not been chosen. EdX cannot offer any extensions.</p>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@catong I feel like there's a better way to phrase this, but I'm not sure what it is

Copy link

@catong catong Dec 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efischer19 How about this:
"All assignment due dates display in the time zone that you select in your account settings. If you do not specify a local time zone, assignment due dates display in your browser's time zone."
Also, I'd like to strike "EdX cannot offer any extensions." It's out of place and confusing here.

@catong
Copy link

catong commented Dec 14, 2016

Thanks! 👍

@efischer19
Copy link
Contributor Author

Latest screenshot:

screen shot 2016-12-14 at 2 04 15 pm

Copy link

@yro yro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid gold.

<p>If an assignment has a due date, you can see the due date in the accordion on the side. (This demo course does not have any due date.) If no due date is displayed, the assignment can be turned in at any time.</p>
<p>All assignment due dates are listed in UTC (the international time standard). Please <a href="http://www.timeanddate.com/worldclock/">look up your time zone</a> in order to understand what time your assignments are due according to your clock. EdX cannot offer any extensions.</p>
<p>If an assignment has a due date, you can see the due date in the sidebar. (This demo course does not have any assignments with due dates.) If no due date is displayed, the assignment can be turned in at any time.</p>
<p>All assignment due dates are listed in the user's specified timezone, defaulting to UTC (the international time standard) if one has not been chosen. EdX cannot offer any extensions.</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, it goes, in order of preference user preference -> system timezone -> UTC. (you can maybe leave out UTC, that's really just a 'nothing worked, so we're bailing out' handler).

@efischer19 efischer19 merged commit 743b552 into master Dec 14, 2016
@nedbat nedbat deleted the efischer/tz_copy branch January 20, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants