Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Point youtube urls to newly uploaded urls #31

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

Carlos-Muniz
Copy link
Contributor

@Carlos-Muniz Carlos-Muniz commented Feb 17, 2022

Description

5 YouTube videos in the edX demo course are no longer available to watch
because the YouTube links don't work (Google made the videos private
back in July and the account hosting the videos has been lost). 3 out
of the 5 videos have been downloaded from AWS and re-uploaded to the
Open edX YouTube account. The course has been updated with the correct
urls. In addition, srt.sjson files names have been changed to reflect
the change in the YouTube video urls.

Testing Information

This course was turned into a gzipped tarball and imported into an empty
course via tutor. The course was then tested to see that the videos
functioned: played, had correct subtitles, and was downloadable.

Other Information

Videos, titled "Science and Cooking Chef Profile: JOSÉ ANDRÉS" and
"Biology Demonstration" will most likely not be found. Instead, it would
be best to choose another video that we do have access to and replace
it. This should be a separate PR.

Closes openedx/axim-engineering#94

4 YouTube videos in the edx demo course are no longer available to watch
because the YouTube links don't work (Google made the videos private
back in July and the account hosting the videos has been lost). 3 out
of the 4 videos have been downloaded from AWS and re-uploaded to the
openedx YouTube account. The course has been updated with the correct
urls. In addition, srt.sjson files names have been changed to reflect
the change in the YouTube video urls.
@Carlos-Muniz Carlos-Muniz self-assigned this Feb 17, 2022
@nedbat
Copy link
Contributor

nedbat commented Feb 22, 2022

I don't know enough about the XML structures of courses to review this... :(

@Carlos-Muniz
Copy link
Contributor Author

@nedbat That's okay. Thanks for making this into an issue!

@Carlos-Muniz Carlos-Muniz removed the request for review from nedbat February 23, 2022 14:13
@Carlos-Muniz Carlos-Muniz marked this pull request as ready for review February 23, 2022 14:13
@Carlos-Muniz Carlos-Muniz marked this pull request as draft February 23, 2022 14:15
Copy link

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the typo, it looks good! Thanks @Carlos-Muniz. Once you fix that, I'll approve.

@Carlos-Muniz
Copy link
Contributor Author

There is actually a 5th video that is also missing. The 5th video is titled "Biology Demonstration" and was located at https://youtu.be/gnqth8uWzO8. This video does not have a downloadable link, and can be presumed to be missing as well.

@Carlos-Muniz
Copy link
Contributor Author

A new issue to replace the "lost" videos has been made at #32

@Carlos-Muniz Carlos-Muniz marked this pull request as ready for review February 23, 2022 17:12
Copy link

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, Carlos!

@Carlos-Muniz Carlos-Muniz merged commit 57a1569 into master Feb 23, 2022
@Carlos-Muniz Carlos-Muniz deleted the Carlos-Muniz/videos-fix branch February 23, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The DemoX course needs to have videos fixed
3 participants