Skip to content

Commit

Permalink
refactor: address PR reviews
Browse files Browse the repository at this point in the history
  • Loading branch information
mariajgrimaldi committed Feb 15, 2023
1 parent 5a3fcfc commit 92aeaa8
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 6 deletions.
Empty file.
3 changes: 0 additions & 3 deletions docs/how-tos/adding-events-to-a-service.rst
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
How to add an Open edX Event to a service
=========================================

5. Integrate into service
-------------------------

After or during the events definition implementation, you now must trigger the event in the service you intentioned. Meaning:

- Add the openedx-events library to the service project.
Expand Down
Empty file.
3 changes: 0 additions & 3 deletions docs/how-tos/using-events-with-edx-platform.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ How to use
Using openedx-events in your code is very straight forward. We can consider the
two possible cases, sending or receiving an event.


Receiving events
^^^^^^^^^^^^^^^^

Expand Down Expand Up @@ -80,7 +79,6 @@ attr data classes that encapsulate the event data.
You can do this both from the edx-platform code as well as from an openedx
plugin.


Testing events
^^^^^^^^^^^^^^

Expand Down Expand Up @@ -110,7 +108,6 @@ testing dependencies and make the signal connection in your test case.
# run your assertions
Changes in the openedx-events library that are not compatible with your code
should break this kind of test in CI and let you know you need to upgrade your
code.
Empty file removed docs/references/index.rst
Empty file.

0 comments on commit 92aeaa8

Please sign in to comment.