Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "effort" field from CourseCatalogData #133

Closed
rgraber opened this issue Oct 19, 2022 · 1 comment
Closed

Remove "effort" field from CourseCatalogData #133

rgraber opened this issue Oct 19, 2022 · 1 comment
Assignees
@rgraber
Labels
event-bus Work related to the Event Bus.
Milestone
[Event Bus] Imple...

Comments

@rgraber
Copy link
Contributor

rgraber commented Oct 19, 2022

As per https://github.com/openedx/openedx-events/blob/da9a2a9df07b49bc7760970f58e76de86611ee82/docs/decisions/0009-course-catalog-info-changed-design.rst , we are only using the course catalog info changed signal for setups that include publisher, and we are not including any fields that are not present in studio when publisher is enabled. effort is one of these fields, so we should remove it from the event data.
@rgraber rgraber added the event-bus Work related to the Event Bus. label Oct 19, 2022
@rgraber rgraber self-assigned this Oct 19, 2022
@rgraber rgraber mentioned this issue Oct 19, 2022
Merged
11 tasks
@rgraber
Copy link
Contributor Author

rgraber commented Oct 20, 2022

Note the effort field needs to be removed in edx-platform as well, where we construct a CourseCatalogData object to put on the bus.

@rgraber rgraber mentioned this issue Oct 21, 2022
Merged
@rgraber rgraber closed this as completed Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgraber rgraber

Labels
event-bus Work related to the Event Bus.
Projects
None yet
Milestone
[Event Bus] Implement happy-path
Development

No branches or pull requests
1 participant
@rgraber