Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Requirements Update #137

Closed

Conversation

edx-requirements-bot
Copy link
Contributor

Python requirements update. Please review the changelogs for the upgraded packages.

Deleted obsolete pull_requests:
#135

@edx-requirements-bot edx-requirements-bot requested a review from a team October 31, 2022 00:19
@felipemontoya
Copy link
Member

Hello @rgraber,

It looks like the upgrade from avro 1.6.1 to 1.7.0 would break one of the test.
Specifically it breaks: https://github.com/openedx/openedx-events/blame/main/openedx_events/event_bus/avro/tests/test_avro.py#L97

https://github.com/openedx/openedx-events/actions/runs/3357666334/jobs/5563639919#step:6:34

Does this warrant a change in the test? Should we pin the version to 1.6.1 until this can be resolved?

@rgraber
Copy link
Contributor

rgraber commented Oct 31, 2022

Hello @rgraber,

It looks like the upgrade from avro 1.6.1 to 1.7.0 would break one of the test. Specifically it breaks: https://github.com/openedx/openedx-events/blame/main/openedx_events/event_bus/avro/tests/test_avro.py#L97

https://github.com/openedx/openedx-events/actions/runs/3357666334/jobs/5563639919#step:6:34

Does this warrant a change in the test? Should we pin the version to 1.6.1 until this can be resolved?

We just caught this. This actually requires a code change, but it's a pretty easy change so I'm confident I can get a PR up soon.

@rgraber
Copy link
Contributor

rgraber commented Oct 31, 2022

If you are anxious to get this through you can pin and I can resolve separately.

@felipemontoya
Copy link
Member

If you think a PR might be coming soon I'm cool waiting for it. If it becomes more complicated or something else changes we can re-evaluate.

For now, I'll leave this waiting.

@rgraber
Copy link
Contributor

rgraber commented Oct 31, 2022

I'm still testing end to end but I believe #138 will fix this

@robrap robrap mentioned this pull request Oct 31, 2022
9 tasks
rgraber added a commit that referenced this pull request Oct 31, 2022
@edx-requirements-bot
Copy link
Contributor Author

Closing obsolete PR.

@edx-requirements-bot edx-requirements-bot deleted the jenkins/upgrade-python-requirements-8909df5 branch October 31, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants