Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync from old transifex project #569

Closed
wants to merge 2 commits into from

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Aug 20, 2023

This is a on-demand GitHub Actions workflow which will sync traslations and their status from the open-edx/edx-platform Transifex project (old) into open-edx/openedx-translations OEP-58 project (new).

This is to address @ghassanmas's recommendation on preserving the translated/reviewed status when migrating to the new project.

TODO

  • Merge chore: rename transifex-resources.ini file and upgrade deps #570 first, then merge this PR
  • Run make TX_LANGUAGES=ar SYNC_ARGS='--dry-run' sync_translations_github_workflow to ensure resource slugs are correct
  • Ensure that plural messages translations are synced from old project
  • Test on few resources
  • Enable the rest of the resources

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 20, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@shadinaif
Copy link
Contributor

it's charming @OmarIthawi , thank you! I've pushed a small fix for your review and squash. I also posted on slack the issues found when comparing the original and the new transifex resources

This is a on-demand GitHub Actions workflow which will sync traslations
and their status from the `open-edx/edx-platform` Transifex project
(old) into `open-edx/openedx-translations` OEP-58 project (new).

Refs: FC-0012 OEP-58
@shadinaif shadinaif force-pushed the sync_translations branch 2 times, most recently from 2c7c3a8 to acbbcbf Compare September 18, 2023 08:38
@OmarIthawi
Copy link
Member Author

Closing in favor of #1191

Shadi's taking over this PR.

@OmarIthawi OmarIthawi closed this Sep 18, 2023
@openedx-webhooks
Copy link

@OmarIthawi Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks
Copy link

@OmarIthawi Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants