feat: Add a plugin for the Learner Dashboard MFE #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbrandes
force-pushed
the
learner-dashboard
branch
4 times, most recently
from
29a4f26
to
b2c0c64
Compare
25 tasks
This was referenced Jun 9, 2023
Closed
arbrandes
commented
Jun 9, 2023
| return mfes | ||
|
|
||
| hooks.Filters.ENV_TEMPLATE_VARIABLES.add_items( | ||
| [("learner_dashboard_port", port)] |
There was a problem hiding this comment.
Looking for thoughts here, @regisb: is there a better way to get the port to openedx-lms-development-settings with the new MFE_APPS mechanism?
There was a problem hiding this comment.
Sorry about the very late reply... If it were for me, I would just hardcode the port :-p But I understand it's not very elegant. Instead, we could add a get_mfe utility function to the ENV_TEMPLATE_VARIABLES in the tutor-mfe plugin:
def get_mfe(name: str):
return MFE_APPS.get(name)
tutor_hooks.Filters.ENV_TEMPLATE_VARIABLES.add_item(("get_mfe", get_mfe))
464d84c
to
a273f92
Compare
Adds an experimental plugin for the Learner Dashboard (a.k.a. "Learner Home") MFE.
arbrandes
force-pushed
the
learner-dashboard
branch
from
a273f92
to
08ad6c0
Compare
|
Alright, since this is experimental anyway, I'm going ahead and merging it so we can mention the plugin in the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an experimental plugin for the Learner Dashboard (a.k.a. "Learner Home") MFE.
This is depends on: