fix: remove last margin of elements in Alert (#777)

openedx · Jul 8, 2021 · db0f440 · db0f440
1 parent 203cbfd
commit db0f440
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/src/Alert/Alert.scss b/src/Alert/Alert.scss
@@ -18,7 +18,7 @@
   @include border-radius($alert-border-radius);
   box-shadow: $alert-box-shadow;
 
-  & > :last-child {
+  .alert-message-content > :last-child {
     margin-bottom: 0;
   }
 

diff --git a/src/Alert/__snapshots__/Alert.test.jsx.snap b/src/Alert/__snapshots__/Alert.test.jsx.snap
@@ -25,7 +25,9 @@ exports[`<Alert /> correct rendering renders with correct with icon 1`] = `
       />
     </svg>
   </span>
-  <div>
+  <div
+    className="alert-message-content"
+  >
     Alert
   </div>
 </div>
@@ -36,7 +38,9 @@ exports[`<Alert /> correct rendering renders without icon prop 1`] = `
   className="fade alert-content undefined alert show"
   role="alert"
 >
-  <div>
+  <div
+    className="alert-message-content"
+  >
     Alert
   </div>
 </div>

diff --git a/src/Alert/index.jsx b/src/Alert/index.jsx
@@ -14,7 +14,7 @@ const WrappedAlert = React.forwardRef(({
     ref={ref}
   >
     {icon && <Icon src={icon} className="alert-icon" />}
-    <div>
+    <div className="alert-message-content">
       {children}
     </div>
   </Alert>