Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Active tab background color is white which may not be expected if rendering Tabs on a non-white background #2211

Closed
adamstankiewicz opened this issue Apr 21, 2023 · 1 comment · Fixed by #2222
Closed

Active tab background color is white which may not be expected if rendering Tabs on a non-white background #2211

adamstankiewicz opened this issue Apr 21, 2023 · 1 comment · Fixed by #2222
Assignees
@PKulkoRaccoonGang
Labels
design Design engineering Engineering raccoon-gang

Comments

@adamstankiewicz
Copy link
Member

adamstankiewicz commented Apr 21, 2023 •
edited

https://paragon-openedx.netlify.app/components/tabs/

The active tab styling doesn't quite match the Figma spec given it has a white background for its hover/focus states. It should look more like the following Figma spec: https://www.figma.com/file/eGmDp94FlqEr4iSqy1Uc1K/Paragon-Design-System?node-id=7542-24823&t=t4PotStnrmsyQSoH-4

image

As a result, when Tabs are rendering a non-white background, the active tab always having a white background may not be intended/expected/desired by consumers.
@PKulkoRaccoonGang PKulkoRaccoonGang mentioned this issue Apr 24, 2023
Merged
10 tasks
@PKulkoRaccoonGang PKulkoRaccoonGang self-assigned this Apr 24, 2023
@viktorrusakov viktorrusakov linked a pull request Apr 24, 2023 that will close this issue
[BD-46] feat: refactoring Tabs component #2222
Merged
10 tasks
@openedx openedx deleted a comment from PKulkoRaccoonGang May 12, 2023
@PKulkoRaccoonGang
Copy link
Contributor

PR: #2222

@PKulkoRaccoonGang PKulkoRaccoonGang mentioned this issue May 17, 2023
Closed
@PKulkoRaccoonGang PKulkoRaccoonGang mentioned this issue Nov 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PKulkoRaccoonGang PKulkoRaccoonGang

Labels
design Design engineering Engineering raccoon-gang
Projects
Paragon Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BD-46] feat: refactoring Tabs component raccoongang/paragon
2 participants
@adamstankiewicz @PKulkoRaccoonGang