Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs component renders anchor tag as a child of another anchor tag #2232

Closed
1 task
viktorrusakov opened this issue Apr 27, 2023 · 1 comment
Closed
1 task
Labels
bug Report of or fix for something that isn't working as intended engineering Engineering raccoon-gang

Comments

@viktorrusakov
Copy link
Contributor

viktorrusakov commented Apr 27, 2023

Currently when there are too many Tab components to fit into the Tabs container width we render a More... (see example on the docs site) tab that shows the rest of the tabs, which results in nesting of a tags because each Tab is rendered as an a tag (including the More... tab). According to W3C spec nesting of a tags is not allowed, so we should fix that.

image

Tasks

@adamstankiewicz adamstankiewicz added bug Report of or fix for something that isn't working as intended raccoon-gang engineering Engineering and removed bug Report of or fix for something that isn't working as intended raccoon-gang labels Apr 28, 2023
@PKulkoRaccoonGang
Copy link
Contributor

PKulkoRaccoonGang commented May 17, 2023

Resolved in #2211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended engineering Engineering raccoon-gang
Projects
Status: Done
Development

No branches or pull requests

3 participants